From: Chong Yidong <cyd@stupidchicken.com>
To: Yuri Karaban <tech@askold.net>
Cc: 7438@debbugs.gnu.org
Subject: bug#7438: 23.2; [PATCH] lisp/gnus/pop3.el fix STLS command ordering
Date: Fri, 19 Nov 2010 11:25:27 -0500 [thread overview]
Message-ID: <87ipztp9fs.fsf@stupidchicken.com> (raw)
In-Reply-To: <874obe44r9.fsf@askold.net> (Yuri Karaban's message of "Fri, 19 Nov 2010 00:59:54 +0200")
Yuri Karaban <tech@askold.net> writes:
> Starttls (STLS) is not working with pop3.
>
> There is a bug in current implementation.
>
> Current implementation sends STLS just after opening connection.
>
> As result connection hangs (pop3.el tries to read a greeting message
> after STLS, but all POP3 servers I tried does not send anything after
> successful negotiation). On other hand, ignoring server greeting leads
> to mistreating server greeting (+OK <timestamp>) as successful response
> to STLS command. In this case negotiation starts too early (before
> reading real response to STLS).
>
> I've attached a patch which fixes the problem. The server greeting got
> read first (as with plain POP3) and only after receiving greeting STLS
> issued and TLS negotiation starts.
>
> I hope much this would be fixed in next minor release of emacs.
Looks reasonable. I've checked your patch into the emacs-23 branch.
Thanks.
prev parent reply other threads:[~2010-11-19 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 22:59 bug#7438: 23.2; [PATCH] lisp/gnus/pop3.el fix STLS command ordering Yuri Karaban
2010-11-19 16:25 ` Chong Yidong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipztp9fs.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=7438@debbugs.gnu.org \
--cc=tech@askold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.