From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] rcirc.el (rcirc-connect): Make process name configurable. Date: Sun, 16 Jan 2011 01:20:27 +0100 Message-ID: <87ipxpn1h0.fsf@skangas.se> References: <87aaj3ny3i.fsf@skangas.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1295185923 31194 80.91.229.12 (16 Jan 2011 13:52:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 16 Jan 2011 13:52:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Deniz Dogan , Ryan Yeske Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 16 14:51:59 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PeT1L-0007X2-Ft for ged-emacs-devel@m.gmane.org; Sun, 16 Jan 2011 14:51:54 +0100 Original-Received: from localhost ([127.0.0.1]:45230 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PeSzN-0001aL-O2 for ged-emacs-devel@m.gmane.org; Sun, 16 Jan 2011 08:49:49 -0500 Original-Received: from [140.186.70.92] (port=43725 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PeGMM-0002ah-7Y for emacs-devel@gnu.org; Sat, 15 Jan 2011 19:20:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PeGMK-0007ga-V5 for emacs-devel@gnu.org; Sat, 15 Jan 2011 19:20:42 -0500 Original-Received: from mx2.bahnhof.se ([213.80.101.12]:58914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PeGMK-0007gU-Im for emacs-devel@gnu.org; Sat, 15 Jan 2011 19:20:40 -0500 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx2-reinject (Postfix) with ESMTP id E80D8D517A; Sun, 16 Jan 2011 01:20:37 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF2) Original-Received: from mf2.bahnhof.se ([127.0.0.1]) by localhost (mf2.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v8jcRAgzSZ-1; Sun, 16 Jan 2011 01:20:28 +0100 (CET) Original-Received: from lenin (h-238-133.A219.priv.bahnhof.se [85.24.238.133]) by mf2.bahnhof.se (Postfix) with ESMTP id E2D3A450061; Sun, 16 Jan 2011 01:20:27 +0100 (CET) Original-Received: from skangas by lenin with local (Exim 4.72) (envelope-from ) id 1PeGM8-0002Rk-0j; Sun, 16 Jan 2011 01:20:28 +0100 In-Reply-To: (Deniz Dogan's message of "Sat, 15 Jan 2011 12:14:39 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: FreeBSD 6.x (1) X-Mailman-Approved-At: Sun, 16 Jan 2011 08:49:46 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:134604 Archived-At: --=-=-= Deniz Dogan writes: > Since process-name is > essentially used as an argument to make-network-process, maybe it > would be better if we replace the process-name parameter by a plist > which is passed to make-network-process containing :name. How about the attached patch? Regards, Stefan Kangas --=-=-= Content-Disposition: inline; filename=rcirc-configure-process-v2.txt # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: skangas@skangas.se-20110116000355-aavl1epdl3fvv9su # target_branch: http://bzr.savannah.gnu.org/r/emacs/trunk # testament_sha1: 54e6a9181465f0576d5ab92676c4d626dcd69f0f # timestamp: 2011-01-16 01:10:22 +0100 # base_revision_id: rgm@gnu.org-20110115232357-ja3ha94kwuroxwso # # Begin patch === modified file 'lisp/net/rcirc.el' --- lisp/net/rcirc.el 2011-01-15 23:16:57 +0000 +++ lisp/net/rcirc.el 2011-01-16 00:03:55 +0000 @@ -472,9 +472,11 @@ ;;;###autoload (defun rcirc-connect (server &optional port nick user-name - full-name startup-channels password) + full-name startup-channels password process-plist) (save-excursion (message "Connecting to %s..." server) + (when (not (plist-get process-plist :name)) + (setq (plist-put process-plist :name server))) (let* ((inhibit-eol-conversion) (port-number (if port (if (stringp port) @@ -485,7 +487,8 @@ (user-name (or user-name rcirc-default-user-name)) (full-name (or full-name rcirc-default-full-name)) (startup-channels startup-channels) - (process (make-network-process :name server :host server :service port-number))) + (process (apply 'make-network-process :host server + :service port-number process-plist))) ;; set up process (set-process-coding-system process 'raw-text 'raw-text) (switch-to-buffer (rcirc-generate-new-buffer-name process nil)) # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWRBHxhoAAbH/gFCQAKBQ8//3 UgkIAL////BQA/p73erRzzW167263DJBNNFPBDTaTFPRPQmmQ0ANAGUEaYTBCanpDQ0GgAAADJMS ZKY2pPU8hPKaA0AA0aABtSTTUwyp6aNRp6JtQeoA9QANACSIU9AmqexU21J6ntU8ieZU9QAZM0gi aYjIfW35GHCrpukWbRmBF76sWnHGLfFVCAFI/Wfd06fN3OZAiGL3LmR1qYNrFhEUgrTPNGEfu/F+ v1m9t+a9HOlETWhbERQhq01VYZuRUhFwOSZZT7DGgopYLJVTj4BqSibhenC+jezqmg848VDcGRGv KL9tgWhEDb6qI2U138dA5MJzYhEHjmBPSMG+FgoBNOeD+nUoCmJtFQZcftMprCHQnNEkYquAps3i RIyMCQzyWvAeYYZYHRqyRKzwxwy49Rk0QH0Mbwax1FF0BEEqOIUuaAaXKpdfMWa87b7ARyDVcwzV iBgeCc1clDbGao5jCREa4gxOvepgjUKTLyxoDLCzUBigqumjQWH+zK4IW3wupSmnDSxOSVN8O0lk OpqCoavbwvrWmw2wcNGaxQU5ZMhpkBiFXLzYkIaEuRchInMiIedrXtS+Sl/eUrRMLku90Yh43rbC xxbg5bTRixKC0XOC1/oO5IdAodfKiOCx6goMUUKtY8BfjcEhwDmI8A/LB9Utm2/wjmHQB6mTHk9Z xshWwT4RNo4bNv9XDIgSUi85Zix16Uj1W9A7DpeF+qXXQAu8rNaMSn6oDnGcxA8NKsbNGwOv3nEH QC7c8SQ8e8nUvCiQFzJmtDU6r8BuGt8piMoVjEGmA5RutADaZjxdYaCdYRnJwbJZhku59BxJewCe 3OuVaNO/nedmKOKbu8DY61E/ZItplUchSk0grvTZbRbYhwECZRbOGoJgPt5i4CF1VYUBhWu4OWxd cs+VznPzawWASQHvROAegMduLME09HVrEMxhdwovh+lGLNggoqFdwEOzKSqgNBkB0k8K0xOltRpA GJeH4XYFLBWL1imEYhuWHcKrS5tU5W5d4H5JjKZ/kgL8ov53YcVkWcB9KZ2cCqKbdsg8SAIcJwy4 qwU2DAKIKh1cBin3yDR5HcFXzBilbhh456trzCiGMLUQosVgtfoA0ihyWSsaGgSKpoPPwmkYUUsr 0R2cTNKDUCbCxPSmSequd6zsaAte7QPg03TpsCDd7BRAAZ470otXYNs2va1t4N8AMDAI46rDs4zP LQAUUWoArTA8QUtjVAXVQwQcqwXXBdJy5khv9dae2euu0pCpWMRZbHgRC5SB725EMy18DDFGRmKy tKxHrFE3JiRkuAzmRdQMb8jd127rdQf/i7kinChICCPjDQA= --=-=-=--