From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103854: Reimplementlist-processes in Lisp. Date: Thu, 07 Apr 2011 11:59:25 -0400 Message-ID: <87ipuqf3xe.fsf@stupidchicken.com> References: <87zko2rj4f.fsf@stupidchicken.com> <769DFAFA380F4178A5E5CCC2DCDADAC0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1302192168 10899 80.91.229.12 (7 Apr 2011 16:02:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 7 Apr 2011 16:02:48 +0000 (UTC) Cc: Drew Adams , Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 07 18:02:43 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7rfN-0004Tw-G3 for ged-emacs-devel@m.gmane.org; Thu, 07 Apr 2011 18:02:41 +0200 Original-Received: from localhost ([127.0.0.1]:38186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7rfM-0001jo-Fq for ged-emacs-devel@m.gmane.org; Thu, 07 Apr 2011 12:02:40 -0400 Original-Received: from [140.186.70.92] (port=49131 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7rcI-0000FQ-Nl for emacs-devel@gnu.org; Thu, 07 Apr 2011 11:59:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7rcH-0001Ke-EQ for emacs-devel@gnu.org; Thu, 07 Apr 2011 11:59:30 -0400 Original-Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]:57535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7rcH-0001KI-9V for emacs-devel@gnu.org; Thu, 07 Apr 2011 11:59:29 -0400 Original-Received: from furball (dhcp128036014198.central.yale.edu [128.36.14.198]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p37FxQ0g029272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 7 Apr 2011 11:59:26 -0400 Original-Received: by furball (Postfix, from userid 1000) id E06421604A8; Thu, 7 Apr 2011 11:59:25 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Thu, 7 Apr 2011 12:09:03 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138282 Archived-At: Juanma Barranquero writes: >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8368 > > Thanks, I had forgotten that report. > > I basically agree with the first part, i.e., that it's a mistake to > assume any relationship between temporary and help. Now that we have with-help-window (added by Martin Rudalics in 2007), it makes sense to put help-mode-setup and help-mode-finish there, rather than applying them to all with-output-to-temp-buffer calls. Some uses of temp_output_buffer_setup in the C code may need to be fixed to call help-mode-* explicitly, but that should be easy. As for temp-buffer-setup-hook itself, maybe we should deprecate it. (The name is confusing, since with-temp-buffer does not run it when setting up the buffer.) AFAICT, anything you put in the hook can be accomplished equivalently using the with-output-to-temp-buffer body (one difference is that the hook is run before rebinding standard-output, but probably no one needs this). So, with help-mode-setup moved out into with-help-window, we can dispense with this hook. As for list-* commands not obeying temp-buffer-resize-mode, how about adding a display-buffer-hook, renaming temp-buffer-resize-mode to display-buffer-resize-mode (and moving it from help.el to window.el), and making that mode act on all uses of display-buffer-hook? Then we can probably either deprecate temp-buffer-show-hook or make it an alias for display-buffer-hook.