From: Chong Yidong <cyd@stupidchicken.com>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Drew Adams <drew.adams@oracle.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103854: Reimplementlist-processes in Lisp.
Date: Thu, 07 Apr 2011 11:59:25 -0400 [thread overview]
Message-ID: <87ipuqf3xe.fsf@stupidchicken.com> (raw)
In-Reply-To: <BANLkTikUss+Kb1JD_b2-uMKmi1j88fJ-tA@mail.gmail.com> (Juanma Barranquero's message of "Thu, 7 Apr 2011 12:09:03 +0200")
Juanma Barranquero <lekktu@gmail.com> writes:
>> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8368
>
> Thanks, I had forgotten that report.
>
> I basically agree with the first part, i.e., that it's a mistake to
> assume any relationship between temporary and help.
Now that we have with-help-window (added by Martin Rudalics in 2007), it
makes sense to put help-mode-setup and help-mode-finish there, rather
than applying them to all with-output-to-temp-buffer calls.
Some uses of temp_output_buffer_setup in the C code may need to be fixed
to call help-mode-* explicitly, but that should be easy.
As for temp-buffer-setup-hook itself, maybe we should deprecate it.
(The name is confusing, since with-temp-buffer does not run it when
setting up the buffer.) AFAICT, anything you put in the hook can be
accomplished equivalently using the with-output-to-temp-buffer body (one
difference is that the hook is run before rebinding standard-output, but
probably no one needs this). So, with help-mode-setup moved out into
with-help-window, we can dispense with this hook.
As for list-* commands not obeying temp-buffer-resize-mode, how about
adding a display-buffer-hook, renaming temp-buffer-resize-mode to
display-buffer-resize-mode (and moving it from help.el to window.el),
and making that mode act on all uses of display-buffer-hook? Then we
can probably either deprecate temp-buffer-show-hook or make it an alias
for display-buffer-hook.
next prev parent reply other threads:[~2011-04-07 15:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Q7a6k-0006uE-Q0@colonialone.fsf.org>
2011-04-06 22:35 ` [Emacs-diffs] /srv/bzr/emacs/trunk r103854: Reimplement list-processes in Lisp Juanma Barranquero
2011-04-07 0:38 ` Chong Yidong
2011-04-07 0:57 ` Juanma Barranquero
2011-04-07 2:00 ` [Emacs-diffs] /srv/bzr/emacs/trunk r103854: Reimplementlist-processes " Drew Adams
2011-04-07 10:09 ` Juanma Barranquero
2011-04-07 15:59 ` Chong Yidong [this message]
2011-04-07 17:00 ` Drew Adams
2011-04-07 19:08 ` Chong Yidong
2011-04-08 7:25 ` martin rudalics
2011-04-08 11:03 ` Juanma Barranquero
2011-04-08 12:26 ` martin rudalics
2011-04-08 7:25 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipuqf3xe.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.