From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Inefficiency in Bgotoifnil byte-code instruction Date: Tue, 03 Jul 2012 11:22:14 -0600 Message-ID: <87ipe4vjy1.fsf@fleche.redhat.com> References: <87k3yq2htz.fsf@fleche.redhat.com> <87y5n2vupa.fsf@fleche.redhat.com> <87wr2kvr6g.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1341336150 2615 80.91.229.3 (3 Jul 2012 17:22:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 3 Jul 2012 17:22:30 +0000 (UTC) Cc: Mohamed Ben-Ahssene , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 03 19:22:30 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sm6nz-00061s-PB for ged-emacs-devel@m.gmane.org; Tue, 03 Jul 2012 19:22:27 +0200 Original-Received: from localhost ([::1]:43043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sm6ny-0005xs-Ny for ged-emacs-devel@m.gmane.org; Tue, 03 Jul 2012 13:22:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sm6nw-0005xl-Ho for emacs-devel@gnu.org; Tue, 03 Jul 2012 13:22:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sm6nq-0005Ii-9P for emacs-devel@gnu.org; Tue, 03 Jul 2012 13:22:24 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:14882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sm6nq-0005IH-0F for emacs-devel@gnu.org; Tue, 03 Jul 2012 13:22:18 -0400 Original-Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q63HMGXh012049 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Jul 2012 13:22:17 -0400 Original-Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q63HMFeL000948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 3 Jul 2012 13:22:16 -0400 X-Attribution: Tom In-Reply-To: (Stefan Monnier's message of "Tue, 03 Jul 2012 12:58:58 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151397 Archived-At: >>>>> "Stefan" == Stefan Monnier writes: Stefan> Looks OK. I'm not too fond of all the backslashes and the `value' Stefan> argument to DEFINE, but I guess they're OK. I took the "value" approach because the bytecode values are fixed, and I thought it was safer to be explicit about them. The backslashes are just needed because I made one big #define. Another approach (used in gcc, gdb, etc) is to put the opcode defines into a ".def" file and then include it in multiple places. I can do that if you prefer. Stefan> One more nitpick. You say: >> +/* If BYTE_CODE_THREADED is defined, then the interpreter will be >> + indirect threaded, using GCC's computed goto extension. This is >> + incompatible with BYTE_CODE_SAFE and BYTE_CODE_METER. */ Stefan> But, IIUC there is no incompatibility, really. It's just that the Stefan> current code doesn't handle that particular combination, right? Stefan> If so, please make it clear in the comment. Correct. I'll fix. Tom