From: Tom Tromey <tromey@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Emacs discussions <emacs-devel@gnu.org>
Subject: Re: fix latent bug in process.c
Date: Mon, 13 Aug 2012 15:04:26 -0600 [thread overview]
Message-ID: <87ipcm4i79.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m2mx1ypllb.fsf@igel.home> (Andreas Schwab's message of "Mon, 13 Aug 2012 22:45:36 +0200")
>>>>> "Andreas" == Andreas Schwab <schwab@linux-m68k.org> writes:
Andreas> Tom Tromey <tromey@redhat.com> writes:
>> First, we unconditionally set Writeok, even if SELECT_CANT_DO_WRITE_MASK
>> is set. It seems to me that in one branch we ought to clear Writeok;
>> and only set it in the other.
Andreas> It doesn't matter, since if SELECT_CANT_DO_WRITE_MASK is defined
Andreas> write_mask will always be empty anyway (w32 does not support dbus).
I suppose so, but I think it is more future-proof this way.
The second part is really the interesting one though.
Tom
next prev parent reply other threads:[~2012-08-13 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 19:25 fix latent bug in process.c Tom Tromey
2012-08-13 20:45 ` Andreas Schwab
2012-08-13 21:04 ` Tom Tromey [this message]
2012-08-13 21:19 ` Andreas Schwab
2012-08-14 14:45 ` Tom Tromey
2012-08-15 15:01 ` Andreas Schwab
2012-08-14 6:05 ` Michael Albinus
2012-08-14 7:44 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipcm4i79.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.