From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sergio Durigan Junior Newsgroups: gmane.emacs.devel Subject: [PATCH] Fix bug #11580 Date: Fri, 21 Sep 2012 23:40:42 -0300 Message-ID: <87ipb64w5x.fsf@riseup.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1348288607 14700 80.91.229.3 (22 Sep 2012 04:36:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Sep 2012 04:36:47 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 22 06:36:51 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TFHSU-0004XG-LO for ged-emacs-devel@m.gmane.org; Sat, 22 Sep 2012 06:36:50 +0200 Original-Received: from localhost ([::1]:40504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFHSQ-0007Ip-5t for ged-emacs-devel@m.gmane.org; Sat, 22 Sep 2012 00:36:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFFeE-0003Vi-8e for emacs-devel@gnu.org; Fri, 21 Sep 2012 22:40:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFFeC-00035S-C7 for emacs-devel@gnu.org; Fri, 21 Sep 2012 22:40:50 -0400 Original-Received: from mx1.riseup.net ([204.13.164.18]:38193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFFeC-000348-4i for emacs-devel@gnu.org; Fri, 21 Sep 2012 22:40:48 -0400 Original-Received: from fruiteater.riseup.net (fruiteater-pn.riseup.net [10.0.1.74]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Gandi Standard SSL CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 3BB1D5DD2B for ; Fri, 21 Sep 2012 19:40:46 -0700 (PDT) Original-Received: from localhost (unknown [187.106.37.6]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) (Authenticated sender: sergiodj@fruiteater.riseup.net) by fruiteater.riseup.net (Postfix) with ESMTPSA id 494E0824 for ; Fri, 21 Sep 2012 19:40:44 -0700 (PDT) X-URL: http://sergiodj.net/blog X-Virus-Scanned: clamav-milter 0.97.5 at mx1 X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 204.13.164.18 X-Mailman-Approved-At: Sat, 22 Sep 2012 00:36:26 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153450 Archived-At: Hi, The attached patch fixes the bug listed on $SUBJECT. Maybe there are better ways to fix it, but a quick hack did the trick so I am sending it for review. It is the first time I contribute to Emacs, so I don't know if should post this patch elsewhere. I would be glad to receive feedback about it. Thank you, -- Sergio 2012-09-22 Sergio Durigan Junior * net/eudcb-bbdb.el (eudc-bbdb-format-record-as-result): Do not treat empty strings. (Bug#11580). === modified file 'lisp/net/eudcb-bbdb.el' --- lisp/net/eudcb-bbdb.el 2012-01-19 07:21:25 +0000 +++ lisp/net/eudcb-bbdb.el 2012-09-22 02:15:16 +0000 @@ -167,7 +167,7 @@ 'record)))) (t (setq val "Unknown BBDB attribute"))) - (if val + (if (and val (or (listp val) (not (string= val "")))) (cond ((memq attr '(phones addresses)) (setq eudc-rec (append val eudc-rec)))