From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: package.el changes before the feature freeze Date: Mon, 01 Oct 2012 11:11:46 +0800 Message-ID: <87ipau51jh.fsf@gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349061122 30261 80.91.229.3 (1 Oct 2012 03:12:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2012 03:12:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Hackney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 01 05:12:07 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIWQM-0001wE-GB for ged-emacs-devel@m.gmane.org; Mon, 01 Oct 2012 05:12:02 +0200 Original-Received: from localhost ([::1]:60627 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIWQH-0003rn-0a for ged-emacs-devel@m.gmane.org; Sun, 30 Sep 2012 23:11:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIWQE-0003ri-Q2 for emacs-devel@gnu.org; Sun, 30 Sep 2012 23:11:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIWQD-0008ED-Nx for emacs-devel@gnu.org; Sun, 30 Sep 2012 23:11:54 -0400 Original-Received: from mail-pa0-f41.google.com ([209.85.220.41]:45596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIWQD-0008Dz-Hs for emacs-devel@gnu.org; Sun, 30 Sep 2012 23:11:53 -0400 Original-Received: by padfa10 with SMTP id fa10so4103665pad.0 for ; Sun, 30 Sep 2012 20:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=mVHL27umTtpFxKGBbA3ASLKem9IT6iQ8VESbRFAumA8=; b=Z2IYc5+M4MT1H3Hi6cS/Nuz1MP4qmd5R6If3Ag3AmkeZlYU9t+9R7iB1qBx8am6qgq ZmX/3peBM7pB1u+RJ8L3wixenNibh3YTs2VzchV9H6nXl+173NIRTjmut5ZLcVM5usx/ 68G4f/RfMD3NU3cCz2mhHL5I/ANYsRUbq6Z9Gjx0K+S/rBkKf6f8kIiWSDufMGIog4s0 1ot4rsgMJfl4W1gOJRp4PZFKrxp8k+5aFlo3Siwp8/JHm8+FhLta9JZyzlfejyUfKd5I GXDWYdJlC81E8oywxx9xQUDvPHlrpngQaY7z0MThqnGqNRrcq8Y1/7NWdZdzDRe1G5Z8 bxtw== Original-Received: by 10.68.191.226 with SMTP id hb2mr37393203pbc.129.1349061112916; Sun, 30 Sep 2012 20:11:52 -0700 (PDT) Original-Received: from ulysses ([155.69.18.66]) by mx.google.com with ESMTPS id s10sm9627461paz.11.2012.09.30.20.11.49 (version=SSLv3 cipher=OTHER); Sun, 30 Sep 2012 20:11:52 -0700 (PDT) In-Reply-To: (Daniel Hackney's message of "Sun, 30 Sep 2012 12:58:47 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.220.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153797 Archived-At: Daniel Hackney writes: > Not all of those features will be done soon, but much of the > refactored base (using `defstruct' for package descriptors instead of > the variety of `cons'ed vectors) is in place. Could I get a few extra > days to get this tested? How much time are you asking for? I'm wary of big changes to package.el (where backward incompatibilities can cause huge headaches) coming out of the blue right before a feature freeze. I took a look at your code, but the changes are too pervasive to easily review, and trying to load the code caused M-x list-packages to spin for a long time followed by Debugger entered--Lisp error: (void-function cl-adjoin) cl-adjoin(((debbugs 0 3) "installed" "SOAP library to access debbugs servers") nil :key car) package-menu--generate(nil t) list-packages(nil) call-interactively(list-packages record nil) I have the debbugs library installed, so I'm guessing your changes screw up existing package installations somehow. Have you altered the on-disk format of installed packages (such as directory layout, the contents of archive-contents, etc.)? If so, I don't think it's suitable for 24.3. Maybe you should split off some of the smaller parts of your altered package.el and commit those separately, saving the rest for post-24.3.