[PATCH] tramp: Avoid "Args out of range" error

[PATCH] tramp: Avoid "Args out of range" error

[Andrew W. Nosenko]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

Attached patch for tramp.el avoids the "Args out of range" error inside
tramp-check-for-regexp.

Such error occurs, for example, when try to compile through tramp with
FreeBSD-9.1 as remote host.

-- 
Andrew W. Nosenko <andrew.w.nosenko@gmail.com>

[-- Attachment #2: 0001-tramp-Avoid-Args-out-of-range-error.patch --]
[-- Type: application/octet-stream, Size: 1259 bytes --]

From 150aaaba5ae485af1cce1d751dd95eb0cdf46b6c Mon Sep 17 00:00:00 2001
From: "Andrew W. Nosenko" <andrew.w.nosenko@gmail.com>
Date: Thu, 31 Jan 2013 14:36:43 +0200
Subject: [PATCH] tramp: Avoid "Args out of range" error

Such error occurs, for example, when try to compile through tramp with
FreeBSD-9.1 as remote host.

* lisp/net/tramp.el (tramp-check-for-regexp): Avoid "Args out of range"
error when buffer in question is narrowed so position 1 is out of visible
part.
---
 lisp/net/tramp.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 4f31e95..2f18db7 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -3413,7 +3413,8 @@ Erase echoed commands if exists."
 		     0 (min tramp-echo-mark-marker-length (1- (point-max))))
 		    (tramp-compat-funcall
 		     'buffer-substring-no-properties
-		     1 (min (1+ tramp-echo-mark-marker-length) (point-max))))))
+		     (point-min)
+		     (min (+ (point-min) (1+ tramp-echo-mark-marker-length)) (point-max))))))
       ;; No echo to be handled, now we can look for the regexp.
       ;; Sometimes, lines are much to long, and we run into a "Stack
       ;; overflow in regexp matcher".  For example, //DIRED// lines of
-- 
1.8.1.2

Re: [PATCH] tramp: Avoid "Args out of range" error

[Michael Albinus]

"Andrew W. Nosenko" <andrew.w.nosenko@gmail.com> writes:

Hi Andrew,

> Attached patch for tramp.el avoids the "Args out of range" error inside
> tramp-check-for-regexp.
>
> Such error occurs, for example, when try to compile through tramp with
> FreeBSD-9.1 as remote host.

Thanks for the patch, it makes sense. But I believe it is incorrect, it
should be

	    (tramp-compat-funcall
	     'buffer-substring-no-properties
	     (point-min)
	     (min (+ (point-min) tramp-echo-mark-marker-length) (point-max))))))

I would like to install it in the emacs-24 branch, are there objections?
Glenn? Stefan?

> Andrew W. Nosenko <andrew.w.nosenko@gmail.com>

Best regards, Michael.

Re: [PATCH] tramp: Avoid "Args out of range" error

[Andrew W. Nosenko]

On Fri, Feb 1, 2013 at 9:11 PM, Michael Albinus <michael.albinus@gmx.de> wrote:
> "Andrew W. Nosenko" <andrew.w.nosenko@gmail.com> writes:
>
> Hi Andrew,
>
>> Attached patch for tramp.el avoids the "Args out of range" error inside
>> tramp-check-for-regexp.
>>
>> Such error occurs, for example, when try to compile through tramp with
>> FreeBSD-9.1 as remote host.
>
> Thanks for the patch, it makes sense. But I believe it is incorrect, it
> should be
>
>             (tramp-compat-funcall
>              'buffer-substring-no-properties
>              (point-min)
>              (min (+ (point-min) tramp-echo-mark-marker-length) (point-max))))))
>

Thanks for catch!

-- 
Andrew W. Nosenko <andrew.w.nosenko@gmail.com>

Re: [PATCH] tramp: Avoid "Args out of range" error

[Stefan Monnier]

> I would like to install it in the emacs-24 branch, are there objections?

IIUC this just replaces 1 with point-min, which seems safe here, so it
hink it's OK.


        Stefan

Re: [PATCH] tramp: Avoid "Args out of range" error

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I would like to install it in the emacs-24 branch, are there objections?
>
> IIUC this just replaces 1 with point-min, which seems safe here, so it
> hink it's OK.

Installed.

>         Stefan

Best regards, Michael.