From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests! Date: Tue, 12 Mar 2013 14:13:47 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87ip4wpjtw.fsf@lifelogs.com> References: <87mwu9l6ju.fsf@fleche.redhat.com> <87obeog70m.fsf@yandex.ru> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1363112352 8214 80.91.229.3 (12 Mar 2013 18:19:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Mar 2013 18:19:12 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 12 19:19:37 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UFTnT-00011K-Cd for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 19:19:35 +0100 Original-Received: from localhost ([::1]:48504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFTn6-0001RH-U7 for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 14:19:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFTm0-0001M0-7W for emacs-devel@gnu.org; Tue, 12 Mar 2013 14:19:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFTi2-0007gP-BR for emacs-devel@gnu.org; Tue, 12 Mar 2013 14:18:04 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:50140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFTi2-0007gL-4a for emacs-devel@gnu.org; Tue, 12 Mar 2013 14:13:58 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UFTiN-0005na-7d for emacs-devel@gnu.org; Tue, 12 Mar 2013 19:14:19 +0100 Original-Received: from pool-72-70-84-108.bstnma.east.verizon.net ([72.70.84.108]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 12 Mar 2013 19:14:19 +0100 Original-Received: from tzz by pool-72-70-84-108.bstnma.east.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 12 Mar 2013 19:14:19 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 24 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: pool-72-70-84-108.bstnma.east.verizon.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:Rqrf1EWHz5+ygHVbwI1rtGaepe0= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157791 Archived-At: On Tue, 12 Mar 2013 16:03:05 +0400 Dmitry Gutov wrote: DG> Tom Tromey writes: Daniel> The changes touch most of the code, but the overall structure of the Daniel> code has not changed significantly. Some parts of the code which were Daniel> questionable in the first place (such as using `tar-mode' to extract tar Daniel> archives) have been replaced with simpler alternatives. In the case of Daniel> tar, the file is simply downloaded to a temporary directory and Daniel> extracted using "tar xaf foo-1.2.3.tar". >> >> This sounds worse to me, since it means that now package installation >> has an external dependency. Previously this was not the case -- >> intentionally. DG> Indeed, if that means that it won't work on vanilla Windows DG> installations, then this decision should be reversed. Agreed, maybe Daniel can explain why using `tar-mode' was questionable. Performance? DG> The change looks good otherwise, I especially like the presence of tests. Same here. I like the standardization of the internals. Ted