From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#14568: 24.3.50; ring.el: Subtle issue with duplicate "value" entries Date: Thu, 06 Jun 2013 22:54:40 +0530 Message-ID: <87ip1rxicn.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1370539511 13057 80.91.229.3 (6 Jun 2013 17:25:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Jun 2013 17:25:11 +0000 (UTC) To: 14568@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 06 19:25:11 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ukdvt-00089P-Ca for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Jun 2013 19:25:05 +0200 Original-Received: from localhost ([::1]:36942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukdvs-0000dK-RL for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Jun 2013 13:25:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukdvk-0000W5-VE for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2013 13:25:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ukdvg-00037O-83 for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2013 13:24:56 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukdvg-00037K-4d for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2013 13:24:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Ukdxl-000195-MS for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2013 13:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jun 2013 17:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14568 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13705396114383 (code B ref -1); Thu, 06 Jun 2013 17:27:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Jun 2013 17:26:51 +0000 Original-Received: from localhost ([127.0.0.1]:54695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ukdxa-00018Z-Id for submit@debbugs.gnu.org; Thu, 06 Jun 2013 13:26:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49767) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UkdxY-00018I-9c for submit@debbugs.gnu.org; Thu, 06 Jun 2013 13:26:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkdvI-00030H-9a for submit@debbugs.gnu.org; Thu, 06 Jun 2013 13:24:32 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:35848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkdvI-00030C-6B for submit@debbugs.gnu.org; Thu, 06 Jun 2013 13:24:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkdvD-0000NP-7Q for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2013 13:24:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ukdv6-0002y8-GB for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2013 13:24:23 -0400 Original-Received: from mail-pd0-f180.google.com ([209.85.192.180]:36221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukdv6-0002y2-9B for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2013 13:24:16 -0400 Original-Received: by mail-pd0-f180.google.com with SMTP id 10so3636279pdi.39 for ; Thu, 06 Jun 2013 10:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=ODuJdDrhalyhjoIwkwtdEIJgmzlzCJ4YrF4OISUsIsw=; b=yNVc9NJh8Ld0MA5U0U5y/J9pY3THvxWzwDl+FVgpBQ38eQyxO7O1WwMUtakjV4ZLpw YKJ5eFfHoNzAFskDTU5IXTPr5pG4RNDofy+3QUrozNk8KfFw8Y8Anao40BYB8LRAfGRe whMcL4gtK4Zz3GpjRzs3GXnbn784prAnber/oDu8GM6DKXfzuw9axrlIzCyiGoH5hv40 l36GtyF0WJXHptytaKQyoNwJg5QPZOVX+AmbWMfba4RmjwQn/XLIST7cBEe1U1tdSNV3 SkQifMbRPjd79xPNL6NKWJv9gNrHvORy4JJwUjmkaH082TXOar1Q9aQMVXH4pihGmsjL MJ+g== X-Received: by 10.66.252.133 with SMTP id zs5mr39756410pac.47.1370539455282; Thu, 06 Jun 2013 10:24:15 -0700 (PDT) Original-Received: from debian-6.05 ([115.241.37.197]) by mx.google.com with ESMTPSA id qi1sm78549063pac.21.2013.06.06.10.24.12 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 06 Jun 2013 10:24:14 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74847 Archived-At: `search-mark-ring' is a variable that I have in my private library. This is a ring that is created using ring.el and is used to store markers. M-: search-mark-ring (0 5 . [ # # # # # nil nil nil nil nil nil nil nil nil nil nil]) M-: search-mark-ring-current # M-: (setq search-mark-ring-current (ring-next search-mark-ring search-mark-ring-current)) When the last form is repeatedly evaluated, you will see that there is no way I can hit the oldest marker - the one at 4503 - in the ring. This is because there are duplicate entries in 109654. Possible solutions: 1. `ring-member' should use `eq' instead of `equal'. 2. `ring-insert' should check for duplicate entries before insertion. I would prefer solution (1). ring.el is probably one of the oldest libraries and so (1) may break existing behaviours. Possible bugfix. 1. Augment the structure and allow for a predicate. 2. Check if the ring is a ring of markers and use `eq' instead of `equal'. ps: It is a requirement that ring be robust in presence of duplicate entries. In GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 2.20.1) of 2013-06-06 on debian-6.05 Bzr revision: 112866 acm@muc.de-20130605205709-0cwqswy801vgkyx8 Windowing system distributor `The X.Org Foundation', version 11.0.10707000 Important settings: value of $LANG: en_IN locale-coding-system: iso-latin-1-unix default enable-multibyte-characters: t Major mode: Emacs-Lisp