all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Claudio Bley <claudio.bley@googlemail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 2/5] w32: add support for recent PNG library version >= 1.5
Date: Tue, 29 Oct 2013 09:44:01 +0100	[thread overview]
Message-ID: <87iowgv54e.wl%claudio.bley@gmail.com> (raw)
In-Reply-To: <83hac2fzkl.fsf@gnu.org>

At Sun, 27 Oct 2013 18:28:26 +0200,
Eli Zaretskii wrote:
> 
> Here, too, latest libpng versions are incompatible with 1.4.x, so we
> do need to make such a change.
> 
> However, when one builds libpng-X.Y.Z on Windows, the DLL that is
> installed is called libpngXY-XY.dll, not just libpngXY.dll, as your
> patch assumes.

I'm building with CMake and that's what the CMake builds produce.

If you download the release tarball (lpng166.7z) for win32, the DLL
produced is also called libpng16.dll.

> I don't mind supporting both forms, but we must support the form
> used by "make install" in the libpng distribution.
> 
> So could you please modify this patch accordingly?

OK, I'll add libpngXY-XY.dll as a second alternative, since
libpngXY.dll seems to be the platform default.



  reply	other threads:[~2013-10-29  8:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1382714399.git.claudio.bley@gmail.com>
2013-10-25 15:35 ` [PATCH 1/5] w32: define new jpeglib-version var in order to load the correct DLL at runtime Claudio Bley
2013-10-27 16:25   ` Eli Zaretskii
2013-10-25 15:36 ` [PATCH 2/5] w32: add support for recent PNG library version >= 1.5 Claudio Bley
2013-10-27 16:28   ` Eli Zaretskii
2013-10-29  8:44     ` Claudio Bley [this message]
2013-10-29 16:50       ` Eli Zaretskii
2013-10-30 12:50         ` Claudio Bley
2013-11-01  9:21           ` Eli Zaretskii
2013-10-25 15:36 ` [PATCH 3/5] w32: add support for default library names for libtiff Claudio Bley
2013-10-27 16:30   ` Eli Zaretskii
2013-10-25 15:36 ` [PATCH 4/5] Fix parsing of NetPBM file comments Claudio Bley
2013-10-25 15:37 ` [PATCH 2/5] w32: add support for recent PNG library version >= 1.5 Claudio Bley
2013-10-29  8:10 ` [PATCH 5/5] Fix file magic for pbm files with comments Claudio Bley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iowgv54e.wl%claudio.bley@gmail.com \
    --to=claudio.bley@googlemail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.