From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vitalie Spinu Newsgroups: gmane.emacs.devel Subject: [PATCH] make ido show known tramp host in read-directory-name Date: Tue, 19 Nov 2013 19:10:19 -0800 Organization: UCLA Anderson School of Management Message-ID: <87iovnu5t0.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1384917046 32190 80.91.229.3 (20 Nov 2013 03:10:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Nov 2013 03:10:46 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 20 04:10:50 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ViyBk-0008Rx-KH for ged-emacs-devel@m.gmane.org; Wed, 20 Nov 2013 04:10:48 +0100 Original-Received: from localhost ([::1]:52609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViyBk-0006bp-4q for ged-emacs-devel@m.gmane.org; Tue, 19 Nov 2013 22:10:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViyBa-0006Wf-N2 for emacs-devel@gnu.org; Tue, 19 Nov 2013 22:10:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViyBU-0004VI-IH for emacs-devel@gnu.org; Tue, 19 Nov 2013 22:10:38 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:51218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViyBU-0004VA-7d for emacs-devel@gnu.org; Tue, 19 Nov 2013 22:10:32 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ViyBR-0008Gb-QH for emacs-devel@gnu.org; Wed, 20 Nov 2013 04:10:29 +0100 Original-Received: from cs178-204.anderson.ucla.edu ([164.67.178.204]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 20 Nov 2013 04:10:29 +0100 Original-Received: from spinuvit by cs178-204.anderson.ucla.edu with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 20 Nov 2013 04:10:29 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 56 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: cs178-204.anderson.ucla.edu User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:5uvQEC84s7hqrT8jk8NRpFGhNjM= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165419 Archived-At: --=-=-= Content-Type: text/plain Hi, Ido doesn't show known hosts with read-directory-name with tramp directories. For example /ssh: or /ftp: show completions on read-file-name, but not on read-directory-name. This simple patch fixes that. If I am not mistaken this was also a request of bug#10911: http://emacs.1067599.n5.nabble.com/bug-10911-24-0-94-ido-read-directory-name-should-offer-known-hosts-for-completion-td4703.html Vitalie --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-make-ido-make-dir-list-1-show-known-host.patch >From eeb19169db1e0b3223abfe0e9ed3e76ddcbaa21a Mon Sep 17 00:00:00 2001 From: Vitalie Spinu Date: Tue, 19 Nov 2013 18:52:35 -0800 Subject: [PATCH 1/1] make ido-make-dir-list-1 show known host ido-final-slash checks for tramp directory and acts accordingly, but it never gets the full directory name when it is called from ido-make-dir-list-1. --- lisp/ido.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/ido.el b/lisp/ido.el index 42b3607..f6104a6 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -3676,7 +3676,8 @@ If MERGED is non-nil, each subdir is cons'ed with DIR." (delq nil (mapcar (lambda (name) - (and (ido-final-slash name) (not (ido-ignore-item-p name ido-ignore-directories)) + (and (ido-final-slash (concat dir name)) + (not (ido-ignore-item-p name ido-ignore-directories)) (if merged (cons name dir) name))) (ido-file-name-all-completions dir))))) -- 1.8.1.2 --=-=-=--