From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#14029: 24.2.50; [PATCH] imenu problems with special elements Date: Mon, 25 Nov 2013 01:53:09 +0200 Message-ID: <87iovhqrve.fsf@yandex.ru> References: <87hak4gram.fsf@fh-trier.de> <5ABDF35DFCF64DEEAA37AFAE5048578D@us.oracle.com> <87ip4iwfoe.fsf@fh-trier.de> <878v5ew1pp.fsf@fh-trier.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385337264 29342 80.91.229.3 (24 Nov 2013 23:54:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Nov 2013 23:54:24 +0000 (UTC) Cc: 14029@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 25 00:54:28 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VkjVT-0003nV-2U for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2013 00:54:27 +0100 Original-Received: from localhost ([::1]:48967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkjVS-0000AH-K3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Nov 2013 18:54:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkjVK-000093-0I for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 18:54:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkjV4-0006bP-Vz for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 18:54:17 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkjV4-0006bL-Ng for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 18:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VkjV4-0007S3-4s for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 18:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Nov 2013 23:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14029 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14029-submit@debbugs.gnu.org id=B14029.138533720628592 (code B ref 14029); Sun, 24 Nov 2013 23:54:02 +0000 Original-Received: (at 14029) by debbugs.gnu.org; 24 Nov 2013 23:53:26 +0000 Original-Received: from localhost ([127.0.0.1]:42955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkjUT-0007R6-Hi for submit@debbugs.gnu.org; Sun, 24 Nov 2013 18:53:26 -0500 Original-Received: from mail-wi0-f181.google.com ([209.85.212.181]:62545) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkjUR-0007Qs-F0 for 14029@debbugs.gnu.org; Sun, 24 Nov 2013 18:53:24 -0500 Original-Received: by mail-wi0-f181.google.com with SMTP id hq4so3271498wib.14 for <14029@debbugs.gnu.org>; Sun, 24 Nov 2013 15:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=K2fXb2BCfH6ADnNBRU81QAJsOqf4tzlCXXuSPn4qbeQ=; b=lzQj0JN5q72edAbm3slpU++Wx6gkdUNXZf/8XcrGyedH1kiyhje7U+TFsC05LLLez+ CcPXQoXotBq2S66zJ6bEN6NDMoMGYoabrbykKFyCFsTjNfjoM7KDAZIWwyBUFLDREDnk x/+LBVNrfWDu/vgkWZ75QHKmr9+VN1nLmfdCtGUseDMbUMYfQIsL/Jcf93SCSH0WSPGS I9mJFC8OA4B7ZNZGDdZba7yjWkBpuM2BcAvCIugNxxEkwZT09wqweh4uL42F4oTtrD9w ZGm5xhdNXCF2G/nLteiOegS0MYNwtFhm4fl1RiU1OUKVtbqli2849OIRrz59NHlUxxIX gKeA== X-Received: by 10.180.75.46 with SMTP id z14mr11168836wiv.58.1385337197433; Sun, 24 Nov 2013 15:53:17 -0800 (PST) Original-Received: from axl ([93.109.200.157]) by mx.google.com with ESMTPSA id g16sm1438425wiw.6.2013.11.24.15.53.14 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 24 Nov 2013 15:53:15 -0800 (PST) In-Reply-To: <878v5ew1pp.fsf@fh-trier.de> (Andreas Politz's message of "Sat, 23 Mar 2013 16:54:58 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80924 Archived-At: Hi there, Andreas Politz writes: >> Let's recap. The three types are: >> >> (INDEX-NAME . INDEX-POSITION) >> (INDEX-NAME INDEX-POSITION FUNCTION ARGUMENTS...) >> (MENU-TITLE SUB-ALIST) >> >> First, I think the documentation is incorrect, and the last one should read >> >> (MENU-TITLE . SUB-ALIST) >> >> since SUB-ALIST is supposed to be the cdr of the list (see >> e.g. imenu--split-submenus) Is this documentation fix supposed to be included in the patch? I only see source code changes in it. Aside from that, you should consider including a proper ChangeLog entry in the patch (with detailed descriptions, as is the custom). Without it and a reproduction recipe, I'm having hard time understanding what change does what, too. The patchy description in email replies doesn't really cut it. Also note that your last reply is one huge quote.