all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Andreas Politz <politza@fh-trier.de>
Cc: 14029@debbugs.gnu.org
Subject: bug#14029: 24.2.50; [PATCH] imenu problems with special elements
Date: Mon, 25 Nov 2013 01:53:09 +0200	[thread overview]
Message-ID: <87iovhqrve.fsf@yandex.ru> (raw)
In-Reply-To: <878v5ew1pp.fsf@fh-trier.de> (Andreas Politz's message of "Sat, 23 Mar 2013 16:54:58 +0100")

Hi there,

Andreas Politz <politza@fh-trier.de> writes:

>> Let's recap.  The three types are:
>>
>> (INDEX-NAME . INDEX-POSITION)
>> (INDEX-NAME INDEX-POSITION FUNCTION ARGUMENTS...)
>> (MENU-TITLE SUB-ALIST)
>>
>> First, I think the documentation is incorrect, and the last one should read
>>
>> (MENU-TITLE . SUB-ALIST)
>>
>> since SUB-ALIST is supposed to be the cdr of the list (see
>> e.g. imenu--split-submenus)

Is this documentation fix supposed to be included in the patch? I only
see source code changes in it.

Aside from that, you should consider including a proper ChangeLog entry
in the patch (with detailed descriptions, as is the custom).  Without
it and a reproduction recipe, I'm having hard time understanding what
change does what, too.

The patchy description in email replies doesn't really cut it.  Also
note that your last reply is one huge quote.





  parent reply	other threads:[~2013-11-24 23:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22  1:24 bug#14029: 24.2.50; [PATCH] imenu problems with special elements Andreas Politz
2013-03-22  5:12 ` Drew Adams
     [not found]   ` <87ip4iwfoe.fsf@fh-trier.de>
2013-03-23 15:54     ` Andreas Politz
2013-03-23 16:15       ` Drew Adams
2013-11-24 23:53       ` Dmitry Gutov [this message]
2013-11-25  1:32         ` Andreas Politz
2013-11-25  1:40           ` Andreas Politz
2013-11-25  1:32         ` Andreas Politz
2013-11-29  3:43           ` Dmitry Gutov
2013-11-29 13:36             ` Andreas Politz
2013-11-29 14:35               ` Dmitry Gutov
2013-11-29 15:34               ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iovhqrve.fsf@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=14029@debbugs.gnu.org \
    --cc=politza@fh-trier.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.