From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 0/5] EWW: Various minor fixes Date: Sat, 21 Dec 2013 15:14:48 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87iouidkqv.fsf@flea.lifelogs.com> References: <4012718.hTuAY6Y1qG@descartes> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1387656818 25550 80.91.229.3 (21 Dec 2013 20:13:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Dec 2013 20:13:38 +0000 (UTC) Cc: Lars Magne Ingebrigtsen , emacs-devel@gnu.org To: =?iso-8859-1?Q?R=FCdiger?= Sonderfeld Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 21 21:13:45 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VuSvh-0003dO-8m for ged-emacs-devel@m.gmane.org; Sat, 21 Dec 2013 21:13:45 +0100 Original-Received: from localhost ([::1]:55435 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuSvg-0002Oe-HR for ged-emacs-devel@m.gmane.org; Sat, 21 Dec 2013 15:13:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuSvZ-0002NM-GT for emacs-devel@gnu.org; Sat, 21 Dec 2013 15:13:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VuSvR-0003KM-7h for emacs-devel@gnu.org; Sat, 21 Dec 2013 15:13:37 -0500 Original-Received: from mail-qe0-x233.google.com ([2607:f8b0:400d:c02::233]:40757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuSvR-0003Jr-2A for emacs-devel@gnu.org; Sat, 21 Dec 2013 15:13:29 -0500 Original-Received: by mail-qe0-f51.google.com with SMTP id 1so3753110qee.24 for ; Sat, 21 Dec 2013 12:13:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type:content-transfer-encoding; bh=JRhDQJMrmnZSPotbgGMEsl7ngQFS5En2AcoJfl0CNPc=; b=O1H7doUQ7Zu2eUZ9+trONdg1YfrX5sPggSsnAwDVSJSf8YO1mp/9t24C7LWh0W3EKl 6lbjYCPa/WffXh43b5FqYQhM4QvI1rAiD8fPXclUJ3ttcgAeb5KPep2237hOO6q3cIgC oZfDBAFKZ/Ztw7CJVH8vQqtxK6xC+o/Eu+uow= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=JRhDQJMrmnZSPotbgGMEsl7ngQFS5En2AcoJfl0CNPc=; b=P0bTtVsipHanoD/TDMpDCpxNtmNWCRWexgIP3Oji0fq5qfT7kMpo0Ody9wVMeU+G0m q+ROVVkm4Wr6bRS+VTArt2zdRQpOBV/QPOEEGpeY1ky8J+q4pPl3QfmXeu//08hvPBjY RIkex2VeJEgOM99DthYQvI2TidfFgfZ7iAvbcG/SPXRafuPUey68dqkmlwBwdESaOzE8 nqHoclLyqd7PJ74Jr3MpWSAnuYWKm15yX/8SR7mgY9EaLIelUN4xiGQJOBZyjRFfutR1 oL8GxA/oVNrO2zeRnGgk8Shtg8DPBkayC2qKsYZoPI2b4BPEHaVUyDCa0jVzAn3WhYH1 xDhw== X-Gm-Message-State: ALoCoQl5tbZMOyI4zXz2qEglf1k35fPmRFtUjj97Qg5xXNipFoCVjUMKzPqqo0vY2Nt6QwC0uNsP X-Received: by 10.49.127.101 with SMTP id nf5mr27556869qeb.61.1387656808219; Sat, 21 Dec 2013 12:13:28 -0800 (PST) Original-Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id f10sm24061424qej.1.2013.12.21.12.13.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Dec 2013 12:13:27 -0800 (PST) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <4012718.hTuAY6Y1qG@descartes> (=?iso-8859-1?Q?=22R=FCdiger?= Sonderfeld"'s message of "Fri, 20 Dec 2013 00:44:09 +0100") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c02::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166707 Archived-At: On Fri, 20 Dec 2013 00:44:09 +0100 R=FCdiger Sonderfeld wrote:=20 RS> I did some minor fixes for eww.el. I guess most changes are uncontrove= rsial.=20=20 RS> But I wanted to check back before committing them. RS> Maybe the tool bar support needs a bit more discussion. I know most us= ers=20 RS> (including me) disable the tool bar anyway. But for the sake of user=20 RS> friendliness we should support it. I only added commands where I could= find=20 RS> an existing icon for in /etc/images. RS> Regards, RS> R=FCdiger RS> R=FCdiger Sonderfeld (5): RS> eww: Use `user-error'. RS> eww: Add menu for `eww-bookmark-mode'. RS> eww: Use `setq-local'. RS> eww: Add tool bar support. RS> eww: Check for `html-mode' using `fboundp'. Since we didn't hear from Lars and all the changes looked good, I committed them, thank you. Lars, please let us know if you object to any of it. Thanks Ted