From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alex Kost Newsgroups: gmane.emacs.bugs Subject: bug#16789: 24.3; load-theme ignores some faces the value of a attribute is nil Date: Wed, 19 Feb 2014 09:56:57 +0400 Message-ID: <87iosbk5li.fsf@gmail.com> References: <874n3xf06z.fsf@kuanyui-laptop.site> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1392789490 21008 80.91.229.3 (19 Feb 2014 05:58:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Feb 2014 05:58:10 +0000 (UTC) Cc: 16789@debbugs.gnu.org To: kuanyui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 19 06:58:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WG0Aj-0004BE-7x for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Feb 2014 06:58:17 +0100 Original-Received: from localhost ([::1]:56592 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG0Ai-00037r-TZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Feb 2014 00:58:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG0Aa-00037i-TB for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 00:58:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG0AU-00045J-TI for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 00:58:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG0AU-00045F-Pn for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 00:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WG0AU-0006Mw-Jg for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 00:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Feb 2014 05:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16789 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16789-submit@debbugs.gnu.org id=B16789.139278943024397 (code B ref 16789); Wed, 19 Feb 2014 05:58:02 +0000 Original-Received: (at 16789) by debbugs.gnu.org; 19 Feb 2014 05:57:10 +0000 Original-Received: from localhost ([127.0.0.1]:59364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WG09d-0006LQ-D4 for submit@debbugs.gnu.org; Wed, 19 Feb 2014 00:57:09 -0500 Original-Received: from mail-lb0-f175.google.com ([209.85.217.175]:44288) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WG09a-0006Kt-Bu for 16789@debbugs.gnu.org; Wed, 19 Feb 2014 00:57:07 -0500 Original-Received: by mail-lb0-f175.google.com with SMTP id p9so12815949lbv.6 for <16789@debbugs.gnu.org>; Tue, 18 Feb 2014 21:57:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=F3MEWUN7hMHCySn2whQ76zzJz0+soSMibJyjkv3A7Es=; b=KlljPUt6S3tpv6JaZnJiN5OYH7Nz0iUOPSBPMGlYqGDHZpwgVF/xJuArDofj7s4VIX QWrtsMhhfyUOChqewGP5+91AHJ/ID25BdyECp1bdY43XE17K4aRte+cSdGD3Q0qXRMj0 ISWJo9w9eYdIFILhJkdBPO2oe6pu6GQ6x24Cyfo5JFnfxpNZqURnXjr76SFbhPb2V/7/ VAfcdRU5kMzEPh57cmzQd7WanweXECNclrjwo84cCwuEmkiaKPkS9+AoSZiup5upKHMC yTJJ7CNbiXSeXVjctprckDyTIzJB9BMdiDzs1pEZ175HWmPC7xD/H/krf7A63Y/Szg+1 VOZQ== X-Received: by 10.152.87.228 with SMTP id bb4mr25065265lab.15.1392789420183; Tue, 18 Feb 2014 21:57:00 -0800 (PST) Original-Received: from leviafan (128-70-201-173.broadband.corbina.ru. [128.70.201.173]) by mx.google.com with ESMTPSA id v5sm35619174laj.0.2014.02.18.21.56.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Feb 2014 21:56:59 -0800 (PST) In-Reply-To: <874n3xf06z.fsf@kuanyui-laptop.site> (kuanyui's message of "Tue, 18 Feb 2014 13:40:20 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:85873 Archived-At: kuanyui (2014-02-18 09:40 +0400) wrote: > load-theme is invalid if a value of a attribute in defface is nil. > Or more accurately, it seems to ignore some faces under some situation. > > > Define a theme, for example, OUR-THEME.el > > Magit inherit its diff faces from diff.el, like this: > > (defface magit-diff-add > '((t :inherit diff-added)) > "Face for lines in a diff that have been added." > :group 'magit-faces) > > If you've defined a face for `diff-added` like this: > > `(diff-added ((((class color) (min-colors 89)) > (:foreground "#008700" :background "#d7ff5f" :bold t)))) > > But now you want to *remove* the :background of `magit-diff-add`, > so add a nil on :background : > > `(magit-diff-add ((((class color) (min-colors 89)) > (:foreground "#008700" :background nil :bold t)))) > > Then, restart Emacs (to ensure Emacs would be "clean"), `require 'magit` > and `load-theme OUR-THEME`; you will found load-theme IGNORES the whole > line defination of magit-diff-add, And magit-diff-add still only > inherits diff-added. > > * Most strange is, if you `find-file` OUR-THEME.el and M-x eval-buffer, > the :background nil TAKE EFFECT. * > > I ask this issue because this strange behavior is an obstacle on > defining theme. It is so in 24.3.1, but it works OK in 24.3.50. You may look at for details.