From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#17218: 24.3; Dired does not insert subdirs when used with switch "--group-directories-first" Date: Sat, 03 May 2014 12:23:54 +0300 Organization: JURTA Message-ID: <87iopn43md.fsf@mail.jurta.org> References: <871twjjhrx.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1399109374 24442 80.91.229.3 (3 May 2014 09:29:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 May 2014 09:29:34 +0000 (UTC) Cc: Tu Do , 17218-done@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 03 11:29:27 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WgWG6-0006tE-Rg for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 11:29:26 +0200 Original-Received: from localhost ([::1]:48107 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgWG6-0004Nf-FV for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 05:29:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgWFs-0004DV-98 for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 05:29:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgWFj-0003RI-Qh for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 05:29:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgWFj-0003R8-Ng for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 05:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgWFj-0001qh-FB for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 05:29:03 -0400 Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 May 2014 09:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 17218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 17218@debbugs.gnu.org, juri@jurta.org, tuhdo1710@gmail.com Original-Received: via spool by 17218-done@debbugs.gnu.org id=D17218.13991093377073 (code D ref 17218); Sat, 03 May 2014 09:29:02 +0000 Original-Received: (at 17218-done) by debbugs.gnu.org; 3 May 2014 09:28:57 +0000 Original-Received: from localhost ([127.0.0.1]:49110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgWFd-0001q1-4a for submit@debbugs.gnu.org; Sat, 03 May 2014 05:28:57 -0400 Original-Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:53450 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgWFa-0001pm-78 for 17218-done@debbugs.gnu.org; Sat, 03 May 2014 05:28:55 -0400 Original-Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id DA13037D128C7C; Sat, 3 May 2014 02:28:50 -0700 (PDT) In-Reply-To: <871twjjhrx.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 27 Apr 2014 11:30:58 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88583 Archived-At: Version: 24.5 >>> I found out the problem in the function "dired-insert-old-subdirs" >>> at line 1367 in dired.el. >> >> There is a similar problem in `dired-sort-R-check' and >> `dired-build-subdir-alist'. >> >> [There probably should be a function that checks for a given switch, >> and does not just use `string-match-p' in such a simple way. >> (At least it should respect case etc.)] > > Below is the implementation of such a function: Installed to trunk since this is not a regression.