From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#17155: 24.3; ELPA files should not appear in recentf Date: Tue, 20 May 2014 05:58:20 +0300 Message-ID: <87iop1w3zn.fsf@yandex.ru> References: <3qd2fvoium.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1400574603 15530 80.91.229.3 (20 May 2014 08:30:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 May 2014 08:30:03 +0000 (UTC) Cc: Jonathan H , 17155@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 20 10:29:56 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WmaGr-00055U-Ec for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 May 2014 04:59:17 +0200 Original-Received: from localhost ([::1]:51073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmaGr-0006LM-5w for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 May 2014 22:59:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmaGj-0006LG-4G for bug-gnu-emacs@gnu.org; Mon, 19 May 2014 22:59:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmaGd-0002TZ-6i for bug-gnu-emacs@gnu.org; Mon, 19 May 2014 22:59:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmaGd-0002TU-2t for bug-gnu-emacs@gnu.org; Mon, 19 May 2014 22:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WmaGb-0000QU-WF for bug-gnu-emacs@gnu.org; Mon, 19 May 2014 22:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 May 2014 02:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17155 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17155-submit@debbugs.gnu.org id=B17155.14005547191600 (code B ref 17155); Tue, 20 May 2014 02:59:01 +0000 Original-Received: (at 17155) by debbugs.gnu.org; 20 May 2014 02:58:39 +0000 Original-Received: from localhost ([127.0.0.1]:53703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmaGE-0000Ph-Pc for submit@debbugs.gnu.org; Mon, 19 May 2014 22:58:39 -0400 Original-Received: from mail-wi0-f171.google.com ([209.85.212.171]:55636) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmaG8-0000PF-4s for 17155@debbugs.gnu.org; Mon, 19 May 2014 22:58:36 -0400 Original-Received: by mail-wi0-f171.google.com with SMTP id cc10so2515907wib.16 for <17155@debbugs.gnu.org>; Mon, 19 May 2014 19:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=CGC4bpsPwbU1gfyQFeAGcoFK9N4Rz3ErMFsyUUnogiY=; b=lU5hMOpEHlp7hJOwmOg1gl0rFJb7/modhe2LgVlk5MlIz8rg4hB7dtJ4oZ9qxdP6Ie 603ZaGLr1cwHbkEucsp4s1OqNUAaoLUlXMBI7O6eegIIQHk4zRWWe8DLVF/RTpE4pzIV 2K6XmKniLF+iNa2NXBGt9pwpkYLVkk+0GQVNCcVf/Uy6y9SwM8O5lWgISo/ez8OOknfx LBxjxkMN5dHCjjweEfVDW6IfU5SBKyr8Kbce1rtnJpLBg9OvVBiRkYOhT9tZTNreaj5p K4CHMhgQ40hhJmYUvK3BTNKi/hj1sRLfKI9Zt/c+RkyfTeYutY+yhsHDOUXUWm48hGTh RXAg== X-Received: by 10.180.182.19 with SMTP id ea19mr1200280wic.14.1400554706228; Mon, 19 May 2014 19:58:26 -0700 (PDT) Original-Received: from axl (62-151-59.netrun.cytanet.com.cy. [62.228.151.59]) by mx.google.com with ESMTPSA id h3sm18228790wiz.16.2014.05.19.19.58.23 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 19 May 2014 19:58:25 -0700 (PDT) In-Reply-To: <3qd2fvoium.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 02 May 2014 19:34:41 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.90 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89268 Archived-At: Glenn Morris writes: > I think this is because package.el uses `save-buffer'. > > Unless it really needs to do that, I think it should use something more > low-level. The patch below seems to work okay: === modified file 'lisp/emacs-lisp/package.el' --- lisp/emacs-lisp/package.el 2014-03-28 22:47:46 +0000 +++ lisp/emacs-lisp/package.el 2014-05-20 02:53:29 +0000 @@ -1245,9 +1245,7 @@ (when (listp (read (current-buffer))) (make-directory dir t) (setq buffer-file-name (expand-file-name file dir)) - (let ((version-control 'never) - (require-final-newline nil)) - (save-buffer)))) + (basic-save-buffer-1))) (when good-signatures ;; Write out good signatures into archive-contents.signed file. (write-region (mapconcat #'epg-signature-to-string good-signatures "\n") @@ -1495,9 +1493,11 @@ (format "%s-readme.txt" name) (setq buffer-file-name (expand-file-name readme package-user-dir)) - (let ((version-control 'never) - (require-final-newline t)) - (save-buffer)) + (save-excursion + (goto-char (point-max)) + (unless (bolp) + (insert ?\n))) + (basic-save-buffer-1) (setq readme-string (buffer-string)) t)) (error nil))