* Is `gnutls-negotiate' missing a `copy-sequence'?
@ 2014-07-01 15:42 Mario Lang
2014-07-01 16:17 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Mario Lang @ 2014-07-01 15:42 UTC (permalink / raw)
To: emacs-devel
Hi.
Just noticed this piece of code in `gnutls-negotiate':
(verify-error (or verify-error
;; this uses the value of `gnutls-verify-error'
(cond
;; if t, pass it on
((eq gnutls-verify-error t)
t)
;; if a list, look for hostname matches
((listp gnutls-verify-error)
(cl-mapcan
(lambda (check)
(when (string-match (car check) hostname)
(cdr check)))
gnutls-verify-error))
;; else it's nil
(t nil))))
Hmm, `gnutls-verify-error' is a defcustom, and `cl-mapcan' will
destructively modify it. Am I missing something, or should we add a
`copy-sequence' around the `cdr'?
--
CYa,
⡍⠁⠗⠊⠕
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Is `gnutls-negotiate' missing a `copy-sequence'?
2014-07-01 15:42 Is `gnutls-negotiate' missing a `copy-sequence'? Mario Lang
@ 2014-07-01 16:17 ` Stefan Monnier
2014-07-30 20:43 ` Ted Zlatanov
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2014-07-01 16:17 UTC (permalink / raw)
To: Mario Lang; +Cc: emacs-devel
> Hmm, `gnutls-verify-error' is a defcustom, and `cl-mapcan' will
> destructively modify it. Am I missing something, or should we add a
> `copy-sequence' around the `cdr'?
Sounds about right. The destructive nature of cl-mapcan sucks.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Is `gnutls-negotiate' missing a `copy-sequence'?
2014-07-01 16:17 ` Stefan Monnier
@ 2014-07-30 20:43 ` Ted Zlatanov
0 siblings, 0 replies; 3+ messages in thread
From: Ted Zlatanov @ 2014-07-30 20:43 UTC (permalink / raw)
To: emacs-devel
On Tue, 01 Jul 2014 12:17:30 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> Hmm, `gnutls-verify-error' is a defcustom, and `cl-mapcan' will
>> destructively modify it. Am I missing something, or should we add a
>> `copy-sequence' around the `cdr'?
SM> Sounds about right. The destructive nature of cl-mapcan sucks.
Thanks for catching and fixing this, guys. I'll keep this in mind in
the future.
Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-30 20:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-01 15:42 Is `gnutls-negotiate' missing a `copy-sequence'? Mario Lang
2014-07-01 16:17 ` Stefan Monnier
2014-07-30 20:43 ` Ted Zlatanov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.