[PATCH] Improve success message from org-remove-file.

[PATCH] Improve success message from org-remove-file.

[Karl Fogel]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

The attached patch improves the interactive success message from
`org-remove-file'.  Comments / suggestions welcome, of course; I've
tried to follow http://orgmode.org/worg/org-contribute.html here.

Best,
-Karl


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch to improve accuracy of success message from org-remove-file. --]
[-- Type: text/x-diff, Size: 1419 bytes --]

From 846d66a15c73a336c110f5238307242f9192e8c3 Mon Sep 17 00:00:00 2001
From: Karl Fogel <kfogel@red-bean.com>
Date: Mon, 24 Nov 2014 11:32:42 -0600
Subject: [PATCH] org.el: Improve accuracy of message

* lisp/org.el (org-remove-file): Reword success message.

Before this change, when `org-remove-file' succeeded in removing a
file from `org-agenda-files', it would display this unduly alarming
message to the user: "Removed file: foo.org".  This made it seem as
though the file itself were removed from the filesystem, rather than
simply being delisted from `org-agenda-files'.

After this change, the message "Removed from Org Agenda list: foo.org"
is displayed instead, so the user will experience only the normal
level of panic involved in using Org Mode, not the increased panic
that results from thinking a file has been removed when it hasn't.
---
 lisp/org.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 38c5726..9372191 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -18465,7 +18465,7 @@ Optional argument FILE means use this file instead of the current."
 	(progn
 	  (org-store-new-agenda-file-list files)
 	  (org-install-agenda-files-menu)
-	  (message "Removed file: %s" afile))
+	  (message "Removed from Org Agenda list: %s" afile))
       (message "File was not in list: %s (not removed)" afile))))
 
 (defun org-file-menu-entry (file)
-- 
2.1.3

Re: [PATCH] Improve success message from org-remove-file.

[Nicolas Goaziou]

Hello,

Karl Fogel <kfogel@red-bean.com> writes:

> The attached patch improves the interactive success message from
> `org-remove-file'.  Comments / suggestions welcome, of course; I've
> tried to follow http://orgmode.org/worg/org-contribute.html here.

Applied, thank you.

I added "TINYCHANGE" at the end of your commit message.


Regards,

-- 
Nicolas Goaziou

Re: [PATCH] Improve success message from org-remove-file.

[Karl Fogel]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>Karl Fogel <kfogel@red-bean.com> writes:
>
>> The attached patch improves the interactive success message from
>> `org-remove-file'.  Comments / suggestions welcome, of course; I've
>> tried to follow http://orgmode.org/worg/org-contribute.html here.
>
>Applied, thank you.
>
>I added "TINYCHANGE" at the end of your commit message.

Thanks for applying the change.

I didn't include "TINYCHANGE" on purpose.  The guidelines say:

  | If the change is a minor change made by a committer without
  | copyright assignment to the FSF, the commit message should also
  | contain the cookie TINYCHANGE (anywhere in the message). When we
  | later produce the ChangeLog file for Emacs, the change will be
  | marked appropriately.

However, I *do* have copyright assignment on file with the FSF (for
Emacs), so I interpreted the above as meaning I shouldn't include
"TINYCHANGE".  What is the right thing to do here?

Best,
-Karl

Re: [PATCH] Improve success message from org-remove-file.

[Achim Gratz]

Karl Fogel <kfogel <at> red-bean.com> writes:
> However, I *do* have copyright assignment on file with the FSF (for
> Emacs), so I interpreted the above as meaning I shouldn't include
> "TINYCHANGE".  What is the right thing to do here?

The right thing to do is to make the maintainers that will commit your code
aware of that fact.  I see you are already listed as a contributor to
Orgmode w/ assigned copyright.


Regards,
Achim.

Re: [PATCH] Improve success message from org-remove-file.

[Achim Gratz]

Achim Gratz <Stromeko <at> NexGo.DE> writes:
> The right thing to do is to make the maintainers that will commit your code
> aware of that fact.  I see you are already listed as a contributor to
> Orgmode w/ assigned copyright.

Sorry, slip of fingers.  You are still listed as a contributor w/o assigned
copyright.  So since your assignement was cleared you should move this entry
up into the list of contributors with assigned copyright.


Regards,
Achim.

Re: [PATCH] Improve success message from org-remove-file.

[Nicolas Goaziou]

Karl Fogel <kfogel@red-bean.com> writes:

> I didn't include "TINYCHANGE" on purpose.  The guidelines say:
>
>   | If the change is a minor change made by a committer without
>   | copyright assignment to the FSF, the commit message should also
>   | contain the cookie TINYCHANGE (anywhere in the message). When we
>   | later produce the ChangeLog file for Emacs, the change will be
>   | marked appropriately.
>
> However, I *do* have copyright assignment on file with the FSF (for
> Emacs), so I interpreted the above as meaning I shouldn't include
> "TINYCHANGE".  What is the right thing to do here?

Nothing. I didn't know you had copyright assignment. I updated
contributors list accordingly.

Regards,

Re: [PATCH] Improve success message from org-remove-file.

[Bastien]

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Nothing. I didn't know you had copyright assignment. I updated
> contributors list accordingly.

Nicolas, maybe you want to get an account on fencepost.gnu.org
in order to check for copyright assignments* yourself?

If so, just let me know.

Thanks,

* http://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html

-- 
 Bastien