From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karl Fogel Subject: Re: [PATCH] Improve success message from org-remove-file. Date: Tue, 25 Nov 2014 10:12:06 -0600 Message-ID: <87ioi3p8dl.fsf@ktab.red-bean.com> References: <87vbm433gm.fsf@ktab.red-bean.com> <873897ptz7.fsf@selenimh.mobile.lan> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtIiv-0006uP-Q3 for emacs-orgmode@gnu.org; Tue, 25 Nov 2014 11:12:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtIim-0006mN-AY for emacs-orgmode@gnu.org; Tue, 25 Nov 2014 11:12:17 -0500 Received: from mail-ie0-x22d.google.com ([2607:f8b0:4001:c03::22d]:42169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtIim-0006mJ-5H for emacs-orgmode@gnu.org; Tue, 25 Nov 2014 11:12:08 -0500 Received: by mail-ie0-f173.google.com with SMTP id y20so822784ier.4 for ; Tue, 25 Nov 2014 08:12:07 -0800 (PST) Received: from ktab.red-bean.com (74-92-190-113-Illinois.hfc.comcastbusiness.net. [74.92.190.113]) by mx.google.com with ESMTPSA id b123sm772299iob.4.2014.11.25.08.12.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Nov 2014 08:12:07 -0800 (PST) In-Reply-To: <873897ptz7.fsf@selenimh.mobile.lan> (Nicolas Goaziou's message of "Tue, 25 Nov 2014 09:25:32 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nicolas Goaziou writes: >Karl Fogel writes: > >> The attached patch improves the interactive success message from >> `org-remove-file'. Comments / suggestions welcome, of course; I've >> tried to follow http://orgmode.org/worg/org-contribute.html here. > >Applied, thank you. > >I added "TINYCHANGE" at the end of your commit message. Thanks for applying the change. I didn't include "TINYCHANGE" on purpose. The guidelines say: | If the change is a minor change made by a committer without | copyright assignment to the FSF, the commit message should also | contain the cookie TINYCHANGE (anywhere in the message). When we | later produce the ChangeLog file for Emacs, the change will be | marked appropriately. However, I *do* have copyright assignment on file with the FSF (for Emacs), so I interpreted the above as meaning I shouldn't include "TINYCHANGE". What is the right thing to do here? Best, -Karl