From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#19270: 25.0.50; make PDF mode in EWW customizable Date: Thu, 04 Dec 2014 15:04:20 +0000 Message-ID: <87iohro3rf.fsf@violet.siamics.net> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1417705522 3657 80.91.229.3 (4 Dec 2014 15:05:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Dec 2014 15:05:22 +0000 (UTC) To: 19270@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 04 16:05:16 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XwXy0-0008BF-FR for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Dec 2014 16:05:16 +0100 Original-Received: from localhost ([::1]:46298 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwXy0-0000hs-1F for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Dec 2014 10:05:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwXxs-0000fX-FT for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2014 10:05:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwXxo-0007SS-DI for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2014 10:05:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwXxm-0007PT-WB for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2014 10:05:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XwXxm-0001lc-FT for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2014 10:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Dec 2014 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19270-submit@debbugs.gnu.org id=B19270.14177054746753 (code B ref 19270); Thu, 04 Dec 2014 15:05:02 +0000 Original-Received: (at 19270) by debbugs.gnu.org; 4 Dec 2014 15:04:34 +0000 Original-Received: from localhost ([127.0.0.1]:53721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XwXxJ-0001kr-Gp for submit@debbugs.gnu.org; Thu, 04 Dec 2014 10:04:33 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:43459) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XwXxH-0001kd-Lh for 19270@debbugs.gnu.org; Thu, 04 Dec 2014 10:04:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=mqPwF7UviOpC4Md/fWM5GWG5ahduyi8+BB8JvUReMBk=; b=Myut2l5koS1mDikYJS9k67jVYpz2osSJqj7tr8ZqSRTEOPk3sS0Urte6UD0O00w3ZXeJiMvSchGgUU0J2pRF7o5FFpZSWgmNzPw9AfCd5exS7UNzFY84i34bw4+8Z7ED8rB3wk8WXI5okxG4yrbNMzEWWDybbAnI90oVLuDBTo0=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XwXxE-0005Lt-TJ for 19270@debbugs.gnu.org; Thu, 04 Dec 2014 15:04:29 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XwXx7-0004YV-6C for 19270@debbugs.gnu.org; Thu, 04 Dec 2014 22:04:21 +0700 In-Reply-To: (Sebastian Wiesner's message of "Thu, 04 Dec 2014 15:22:08 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96858 Archived-At: >>>>> Sebastian Wiesner writes: > Currently EWW uses `doc-view-mode' to view PDF data. This choice is > hard-coded in `eww-display-pdf' and cannot be customized. > Some users (e. g. http://emacs.stackexchange.com/q/4089/227) however > desire to use alternative PDF modes, e. g. PDF Tools from > https://github.com/axot/pdf-tools. > Please make the PDF mode used by EWW customizable, so that users > don't have to resort to advices in order to change it. My suggestion would be to replace the (cond =E2=80=A6) form in eww-render with something as flexible as: (let ((try-render (run-hook-with-args-until-success eww-render-hook buffer url headers))) (if try-render (with-current-buffer try-render (when (derived-mode-p 'eww-mode) (plist-put eww-data :url url) (eww-update-header-line-format) (setq eww-history-position 0) (run-hooks 'eww-after-render-hook))) (error "No handler for Content-Type: %s (%s)" (car content-type) url))) Where eww-render-hook is a customizable hook with the default value chosen so to imitate the current behavior. (Also, I=E2=80=99d like to suggest replacing the hard-coded input handling in the =E2=80=98eww=E2=80=99 command proper with a similar eww-input-hook, so to be able to add support for urn:ietf:, =E2=80=98!whatever=E2=80=99, etc.) --=20 FSF associate member #7257 np. Man on the Silver Mountain =E2=80=94 Dio = =E2=80=A6 230E 334A