bug#19552: 25.0.50; void-function class-slot-initarg with new EIEIO changes

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sat, 10 Jan 2015 22:06:41 +0200
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: eric@ericabrahamsen.net, 19552@debbugs.gnu.org
>> 
>> > >   $ make file-notify-tests.log
>> > >   make[1]: Entering directory `/d/gnu/git/emacs/trunk/test/automated'
>> > >   Compiling file-notify-tests.el
>> > >
>> > >   In toplevel form:
>> > >   file-notify-tests.el:40:1:Error: Too many arguments to `defclass'
>> > >   Makefile:62: recipe for target `file-notify-tests.elc' failed
>> > >   make[1]: *** [file-notify-tests.elc] Error 1
>> > 
>> > Works for me. Probably you need to bootstrap.
>> 
>> Bootstrap why?  The build is fine, it's just that the test suite (or
>> at least this particular test) fails.
>
> OK, I deleted and regenerated every .elc file that matched "defclass",
> and the problem is gone.

I bootstrapped, and deleted all the relevant elc files in elpa, and a
few other places. Now I'm only getting two errors. One for this bit in
Helm:

(defun helm--create-source (object class)
  "[INTERNAL] Build a helm source from a CLASS OBJECT."
  (cl-loop for s in (object-slots object)
           for slot = (class-slot-initarg class s)
           for slot-val = (slot-value object slot)
           when slot-val
           collect (cons s (unless (eq t slot-val) slot-val))))

Where `class-slot-initarg' no longer exists. I'll open a bug against
helm, but if anyone here knows what the proper replacement is, that
would be helpful.

The other is the "gh" Github-access package from Melpa: that gives "too
many arguments to defclass". In that case it's hard to tell exactly what
the problem is, as there are some strange require loops, apparently to
avoid circular dependencies, but following error messages just goes
round and round the loops. Anyway, that's something for the package
maintainer to fix, I guess.

So, I guess this isn't a bug, but it is a pain for anyone upgrading
incrementally!