From: "Pascal J. Bourguignon" <pjb@informatimago.com>
To: help-gnu-emacs@gnu.org
Subject: Re: elisp newbie: simplifying from cl structures?
Date: Sun, 08 Feb 2015 04:37:38 +0100 [thread overview]
Message-ID: <87iofdnke5.fsf@kuiper.lan.informatimago.com> (raw)
In-Reply-To: mailman.19507.1423366427.1147.help-gnu-emacs@gnu.org
torys.anderson@gmail.com (Tory S. Anderson) writes:
> Thanks for helping me straighten the code out and gain better
> understanding cl-tools and structure; it loads and mostly
> works. Thanks!
>
> (defun change-smtp ()
> "Change the SMTP server according to the current from line."
> (save-excursion
> (cl-loop with from = (save-restriction
> (message-narrow-to-headers)
> (message-fetch-field "from"))
> for (address server port) in smtp-accounts
> do (if (string-match address from)
> (return (funcall 'set-smtp server port address))
> (message "Failed to match %s with %s" address from))
> finally (error "Cannot infer SMTP information."))))
>
> (add-hook 'message-send-mail-hook 'change-smtp)
Ok, but now, you should consider that this functions is performing
several tasks of different order: some parsing of a message is done, as
well as some searching for smtp configuration, and some setting of smtp
configuration. That's a lot for a single function.
It would be better if you split it as follow, which would give you two
nice reusable functions, and makes change-smtp clearer:
(defun message-from-field ()
"Find the from field in the current buffer that must contain a message."
(save-excursion
(save-restriction
(message-narrow-to-headers)
(message-fetch-field "from"))))
(defun find-smtp-account (address accounts)
"Find the first account in `accounts' whose address matches `address'."
(find from accounts :key (function first)
:test (lambda (from address)
(string-match address from))))
(defun change-smtp ()
(let ((from (message-from-field)))
(destructuring-bind (address server port) (find-smtp-account from smtp-accounts)
(if address
(funcall 'set-smtp server port address)
(error "Cannot not infer SMTP information")))))
--
__Pascal Bourguignon__ http://www.informatimago.com/
“The factory of the future will have only two employees, a man and a
dog. The man will be there to feed the dog. The dog will be there to
keep the man from touching the equipment.” -- Carl Bass CEO Autodesk
prev parent reply other threads:[~2015-02-08 3:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 22:39 elisp newbie: simplifying from cl structures? Tory S. Anderson
2015-02-07 23:16 ` John Mastro
2015-02-07 23:26 ` John Mastro
[not found] ` <mailman.19493.1423351600.1147.help-gnu-emacs@gnu.org>
2015-02-08 0:37 ` Pascal J. Bourguignon
2015-02-08 3:33 ` Tory S. Anderson
[not found] ` <mailman.19507.1423366427.1147.help-gnu-emacs@gnu.org>
2015-02-08 3:37 ` Pascal J. Bourguignon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iofdnke5.fsf@kuiper.lan.informatimago.com \
--to=pjb@informatimago.com \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.