From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#20096: 25.0.50; Add Font-Lock support for subr-x macros Date: Sun, 15 Mar 2015 09:25:38 +0100 Message-ID: <87ioe2mzul.fsf@gnu.org> References: <87d24etxni.fsf@gnu.org> <87sid8vvbm.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426407987 16177 80.91.229.3 (15 Mar 2015 08:26:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Mar 2015 08:26:27 +0000 (UTC) Cc: 20096@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 15 09:26:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YX3sD-00035K-FZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Mar 2015 09:26:13 +0100 Original-Received: from localhost ([::1]:42731 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YX3sC-0003kn-Od for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Mar 2015 04:26:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YX3s9-0003kh-Eq for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2015 04:26:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YX3s2-00066Z-MO for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2015 04:26:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YX3s2-00066V-F4 for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2015 04:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YX3s2-00079t-6Y for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2015 04:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Mar 2015 08:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20096 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20096-submit@debbugs.gnu.org id=B20096.142640794627494 (code B ref 20096); Sun, 15 Mar 2015 08:26:02 +0000 Original-Received: (at 20096) by debbugs.gnu.org; 15 Mar 2015 08:25:46 +0000 Original-Received: from localhost ([127.0.0.1]:46922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YX3rm-00079O-5E for submit@debbugs.gnu.org; Sun, 15 Mar 2015 04:25:46 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:57489) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YX3rj-00079E-C2 for 20096@debbugs.gnu.org; Sun, 15 Mar 2015 04:25:44 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id ACE38207A3 for <20096@debbugs.gnu.org>; Sun, 15 Mar 2015 04:25:40 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Sun, 15 Mar 2015 04:25:42 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:cc:subject:references :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=iIgqaeQUyS6lH0PvOkwNbt8Ve2o=; b=Q9e2WixHFLUUSNKcJSae MGp+pue+FVx4Cy5aRgFv+43kMVFPTR9YADM7ZAV9DQ4lBIQmATlASijAogCLV96F 4igEk6TUO3BelnNst/74Ap8pjrTp4khn0PyoCZ6aksGEUidPcf0BDNNR90nI0uJ/ gNqXGoh4heiV7T98qs84uSg= X-Sasl-enc: vNUYKw+vLnIijTjbQxVpeTKQEq3j4TGLnXWLdeqBtJAW 1426407942 Original-Received: from thinkpad-t440p (unknown [2.163.26.221]) by mail.messagingengine.com (Postfix) with ESMTPA id 996B1680109; Sun, 15 Mar 2015 04:25:41 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sat, 14 Mar 2015 09:56:33 -0400") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100490 Archived-At: Stefan Monnier writes: >> but the attached patch uses a regexp defconst with a matcher >> function for font-lock-keywords. > > Looks good. Committed as 51e7e463e93708a0e40688f91200e9e9869ec662 on master. >> +(defun lisp--el-update-after-load (_file) >> + "Update `lisp--el-macro-regexp' and adjust font-lock in existing buffers." >> + (lisp--el-update-macro-regexp) >> + (dolist (buf (buffer-list)) >> + (when (derived-mode-p 'emacs-lisp-mode) >> + (font-lock-flush)))) > > I think we should only flush if the set of macros has changed. Ok, I'm doing that now. > Other than that, the patch looks good. > Have you tried it? Yes, but not long enough. Some non-important special forms such as `if' and `progn' weren't highlighted anymore. So now I consider both macros and special forms. > Does it work well in practice? IMO, yes. The difference is that there are some macros which haven't been highlighted previously, e.g., `push'. Bye, Tassilo