From: Juri Linkov <juri@linkov.net>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: 20351@debbugs.gnu.org, Ken T Takusagawa <kenta@mit.edu>
Subject: bug#20351: isearch-lax-whitespace should be customizable variable
Date: Thu, 02 Jul 2015 01:30:47 +0300 [thread overview]
Message-ID: <87ioa38q94.fsf@mail.linkov.net> (raw)
In-Reply-To: <CAAdUY-LUvVtWzJXPwGFeZEgiiebXAUnKaSpjSy1vKLaOJo1bAA@mail.gmail.com> (Artur Malabarba's message of "Tue, 30 Jun 2015 22:05:03 +0100")
>>>> (defcustom isearch-keep-mode-variables nil
>>>> "A set of search variables to keep between different searches.
>>>> When a search variable is customized to exist in this set, then
>>>> starting a new search doesn't reset the corresponding isearch variable
>>>> to its default value, thus keeping the value from the previous search
>>>> \(changed using toggling commands)."
>>>> :type '(set (const :tag "Case folding" isearch-case-fold-search)
>>>> (const :tag "Character folding" character-fold-search)
>>>> (const :tag "Invisible text" isearch-invisible)
>>>> (const :tag "Filters" isearch-filter-predicate)
>>>> (const :tag "Lax whitespace" isearch-lax-whitespace)
>>>> (const :tag "Regexp lax whitespace" isearch-regexp-lax-whitespace))
>>>> :group 'isearch)
>>>
>>> Though this is not strictly in conflict with turning the individual
>>> variables into defcustoms, I think it's a bit in ideological conflict, and
>>> we should probably pick one of the two.
>>
>> Would it be better to pollute the namespace with N*M more customizable variables
>> like ‘isearch-keep-case-fold-search’, ‘isearch-keep-lax-whitespace’,
>> ‘isearch-initial-case-fold-search’, ‘isearch-initial-lax-whitespace’, I'm not sure.
>
> No. I like the idea of this variable, and I much prefer this defcustom
> over N different `isearch-keep-...' defcustoms.
> What I said is that if we have *this* defcustom, we don't need to turn
> `isearch-lax-whitespace' into a defcustom too (the actual variable,
> not the `keep...' variable).
It seems we can't avoid turning `isearch-lax-whitespace' into a defcustom
because users need to be able to disable these features initially, and
there is no convenient way to customize initial values with a single
defcustom such as ‘isearch-initial-variables’.
‘case-fold-search’ is a customizable variable - and rightfully so
‘char-fold-search’ has to be customizable as well.
next prev parent reply other threads:[~2015-07-01 22:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 22:49 bug#20351: isearch-lax-whitespace should be customizable variable Ken T Takusagawa
2015-06-29 22:30 ` Juri Linkov
2015-06-29 23:10 ` Artur Malabarba
2015-06-30 20:52 ` Juri Linkov
2015-06-30 21:05 ` Artur Malabarba
2015-07-01 22:30 ` Juri Linkov [this message]
2015-07-02 10:15 ` Artur Malabarba
2015-07-04 21:09 ` Juri Linkov
2015-07-04 21:15 ` Artur Malabarba
2015-07-04 22:24 ` Stefan Monnier
2015-07-04 22:42 ` Artur Malabarba
2015-07-05 8:00 ` Andreas Schwab
2015-07-05 16:06 ` Stefan Monnier
2015-07-05 16:27 ` Eli Zaretskii
2015-07-05 18:12 ` Stefan Monnier
2015-07-05 17:56 ` Drew Adams
[not found] ` <<83k2uewovx.fsf@gnu.org>
2015-07-05 17:59 ` Drew Adams
2015-06-29 23:14 ` Drew Adams
2022-04-18 11:36 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioa38q94.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=20351@debbugs.gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=kenta@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.