From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.help Subject: use Elisp to improve your Elisp - some code issues Date: Fri, 31 Jul 2015 02:22:29 +0200 Message-ID: <87io91dvlm.fsf@nl106-137-147.student.uu.se> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1438302283 29742 80.91.229.3 (31 Jul 2015 00:24:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Jul 2015 00:24:43 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Jul 31 02:24:37 2015 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZKy7o-0004JG-Fw for geh-help-gnu-emacs@m.gmane.org; Fri, 31 Jul 2015 02:24:36 +0200 Original-Received: from localhost ([::1]:42624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKy7n-0001DT-TV for geh-help-gnu-emacs@m.gmane.org; Thu, 30 Jul 2015 20:24:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKy7W-000133-Nt for help-gnu-emacs@gnu.org; Thu, 30 Jul 2015 20:24:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKy7R-0006Ad-Ls for help-gnu-emacs@gnu.org; Thu, 30 Jul 2015 20:24:18 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:60570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKy7R-000692-El for help-gnu-emacs@gnu.org; Thu, 30 Jul 2015 20:24:13 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZKy7O-0003vZ-41 for help-gnu-emacs@gnu.org; Fri, 31 Jul 2015 02:24:10 +0200 Original-Received: from nl106-137-228.student.uu.se ([130.243.137.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 31 Jul 2015 02:24:10 +0200 Original-Received: from embe8573 by nl106-137-228.student.uu.se with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 31 Jul 2015 02:24:10 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Original-Lines: 72 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: nl106-137-228.student.uu.se Mail-Copies-To: never User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) Cancel-Lock: sha1:B8EeAiuuUKGyESbfXYhzWmRGdns= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:106158 Archived-At: I just wrote some Elisp which can be used on a set of files to identify for example the construct (if a a b) if you want to replace those for (or a b) See the comments for the issues! Issue one is how to best create a temporary buffer to display the results. Issue two is to not kill buffers that were already open at invocation - I can solve that by checking if there is such a buffer, but I suspect there is a better way to do these kind of things all in the background, rather than the `find-file' and then conditionally `kill-buffer' combo. Third (minor) issue is the annoying message that `downcase' does. Isn't there a (shut-up (do-stuff))? Other comments also appreciated, as always. ;; This file: http://user.it.uu.se/~embe8573/conf/emacs-init/search-regexp-in-files.el (defun files-as-list (file-regexp) (split-string (with-temp-buffer (call-process-shell-command (format "ls %s" file-regexp) nil t) ; no INFILE, temp BUFFER (buffer-substring (point-min) (point-max)) ))) (defun search-regexp-in-files (file-regexp regexp) (let ((paths (files-as-list file-regexp)) (regexp-hits "regexp-hits") ; unlikely, but if there is another such buffer (hits nil)) (with-current-buffer regexp-hits (erase-buffer)) ; then we can't have this (dolist (p paths) (let ((buffer (find-file p))) (with-current-buffer buffer (goto-char (point-min)) (while (re-search-forward regexp nil t) ; no BOUND, NOERROR (setq hits t) (let ((hit-line (downcase (what-line)))) (with-current-buffer regexp-hits (insert (format "file: %s (%s)\n" p hit-line))))) (kill-buffer buffer) ))) ; what if the buffer was open already? ; we only want to kill buffers that we opened (if hits (switch-to-buffer regexp-hits) (message "No hits!") ))) ;; use this to test (when nil ;; find "kill" - should be some hits even for pacifists (search-regexp-in-files "~/.emacs.d/emacs-init/*.el" "kill") ;; find the construct (if a a b) if you want to replace it with (or a b) ;; if it works, when applied to this file, it should find the example above! (search-regexp-in-files (buffer-file-name) "([[:space:]\n]*if[[:space:]\n]+\\(.*\\)[[:space:]\n]+\\1[[:space:]\n]+\\(.*\\))" ) ) (provide 'search-regexp-in-files) -- underground experts united http://user.it.uu.se/~embe8573