From: Oleh Krehel <ohwoeowho@gmail.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Eli Zaretskii <eliz@gnu.org>, Emacs Development <emacs-devel@gnu.org>
Subject: Re: Question on pcase
Date: Mon, 26 Oct 2015 16:55:15 +0100 [thread overview]
Message-ID: <87io5tzkt8.fsf@gmail.com> (raw)
In-Reply-To: <87fv115t20.fsf@web.de> (Michael Heerdegen's message of "Fri, 23 Oct 2015 20:38:31 +0200")
Hi Micheal,
Thanks for your work, it could be useful to many people.
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Someone who wants to try to learn pcase (Oleh? Oleh!) can help by
> reading it and telling me if it is understandable, and send corrections
> - or write a better introduction ;-) - and format it nicely for
> inclusion into Elpa or Emacs when it turns out to help people.
The reason I dislike `pcase' is not because I don't know how to use it
(the basic rules are actually pretty simple), it's because I think it
leads to code that's hard to understand, maintain and transform. I
dislike the trivial `if-let' and `when-let' for the same reasons.
I generally dislike any custom macro that includes `if' or binds
variables. This is because I can't reason about the code that uses these
macros unless I know exactly what they do in terms of binding variables
and selecting branches. These macros don't follow the substitution model
for procedure application (SMPA) [1], which is a valuable debugging
technique for me.
However, I'm willing to implement some tooling that will allow `pcase'
to follow SMPA.
Take this code for example, with "|" being the point:
(pcase which
(`all t)
|(`safe (member fun completion--capf-safe-funs))
(`optimist (not (member fun completion--capf-misbehave-funs))))
Here, the (`all t) branch is selected, and the `which' symbol
can be extracted from the context with `up-list'. I've implemented a
function that prints "pcase: nil" if the selected branch doesn't match,
and "pcase: t" when it matches.
This way, when I'm debugging a code with `pcase' I can see which branch
is the correct one without evaluating the code inside the branch. After
this, I can step into the correct branch and use SMPA.
Of course, this function would also need to bind the same variables that
a `pcase' branch would bind.
Taking your example:
(pcase x
('a 1)
("Hallo" 2)
|(thing (message "%s is neither equal to 'a nor to \"Hallo\"." thing)))
This is what I would like to have:
(equal (macroexpand '(eval-pcase-branch x
(thing (message "%s is neither equal to 'a nor to \"Hallo\"." thing))))
'(progn
(setq thing x)
(message "pcase: t")))
After this, the inner body of the branch can be properly evaluated,
since `thing' is bound to `x' now.
So far, I've implemented some code that can check if each branch will be
followed, see
https://github.com/abo-abo/lispy/commit/d3ed4e4fee435a2a448ddc0722d07cd997ee59d3.
But the code that binds the variables, e.g. (setq thing x) will likely
be hard to implement. For instance, look at this example with macroexpand:
(setq test '(1 . 2))
(pcase test
(`(,foo . ,baz)
(cons baz foo)))
;; =>
;; (2 . 1)
(macroexpand '(pcase test
(`(,foo . ,baz)
(cons baz foo))))
;; =>
;; (if (consp test)
;; (let* ((x (car test))
;; (x (cdr test)))
;; (let ((baz x)
;; (foo x))
;; (cons baz foo)))
;; nil)
The macroexpanded code returns (2 . 2) when evaluated. This I don't
understand. Although, it still works fine with `eval':
(eval (macroexpand '(pcase test
(`(,foo . ,baz)
(cons baz foo)))))
;; =>
;; (2 . 1)
Maybe someone could explain the above, and also suggest the best way the
create variable bindings from a pcase branch.
thanks again,
Oleh
[1]: https://mitpress.mit.edu/sicp/full-text/sicp/book/node10.html
next prev parent reply other threads:[~2015-10-26 15:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 14:46 Question on pcase Oleh Krehel
2015-10-22 21:19 ` Michael Heerdegen
2015-10-23 6:30 ` Eli Zaretskii
2015-10-23 11:58 ` Oleh Krehel
2015-10-23 12:23 ` Michael Heerdegen
2015-10-23 12:42 ` Oleh Krehel
2015-10-23 13:07 ` Michael Heerdegen
2015-10-23 13:26 ` Oleh Krehel
2015-10-23 13:59 ` Michael Heerdegen
2015-10-27 23:50 ` Johan Bockgård
2015-10-30 1:33 ` Michael Heerdegen
2015-10-23 14:23 ` Michael Heerdegen
2015-10-23 12:17 ` Michael Heerdegen
2015-10-23 12:22 ` Oleh Krehel
2015-10-23 13:26 ` Eli Zaretskii
2015-10-23 14:14 ` Michael Heerdegen
2015-10-23 14:41 ` Eli Zaretskii
2015-10-23 18:38 ` Michael Heerdegen
2015-10-23 18:43 ` Eli Zaretskii
2015-10-23 19:59 ` Przemysław Wojnowski
2015-10-23 21:01 ` Michael Heerdegen
2015-10-23 20:23 ` Przemysław Wojnowski
2015-10-23 20:39 ` Michael Heerdegen
2015-10-24 11:37 ` Przemysław Wojnowski
2015-10-24 9:01 ` Alan Mackenzie
2015-10-24 12:58 ` Stephen Berman
2015-10-24 17:47 ` Alan Mackenzie
2015-10-24 19:10 ` Stephen Berman
2015-10-24 19:28 ` Alan Mackenzie
2015-10-25 0:00 ` pcase docstring tweaks (was: Question on pcase) Michael Heerdegen
2015-10-27 14:54 ` pcase docstring tweaks Michael Heerdegen
2015-10-27 18:57 ` Stefan Monnier
2015-10-27 20:14 ` Michael Heerdegen
2015-10-28 3:15 ` Richard Stallman
2015-10-28 17:08 ` Michael Heerdegen
2015-10-24 17:00 ` Question on pcase Drew Adams
2015-10-24 17:22 ` Alan Mackenzie
2015-10-24 17:36 ` Drew Adams
2015-10-24 20:03 ` Johan Bockgård
2015-10-24 23:11 ` Michael Heerdegen
2015-10-26 15:55 ` Oleh Krehel [this message]
2015-10-26 16:07 ` Michael Heerdegen
2015-10-27 8:42 ` Oleh Krehel
2015-10-26 16:20 ` Michael Heerdegen
2015-10-27 8:42 ` Oleh Krehel
2015-10-27 14:27 ` Michael Heerdegen
2015-10-27 14:47 ` Michael Heerdegen
2015-10-28 18:05 ` Michael Heerdegen
2015-10-29 9:44 ` Oleh Krehel
2015-10-30 1:11 ` Michael Heerdegen
2015-10-26 16:35 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io5tzkt8.fsf@gmail.com \
--to=ohwoeowho@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.