From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change f59d1be: Move undo amalgamation to lisp. Date: Wed, 28 Oct 2015 10:01:30 +0000 Message-ID: <87io5r5n2d.fsf@russet.org.uk> References: <20151005134118.10933.50859@vcs.savannah.gnu.org> <87h9m52sh8.fsf@russet.org.uk> <87h9lqbk8m.fsf@russet.org.uk> <87mvvc9g3m.fsf@russet.org.uk> <87wpu8lbtp.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1446026522 20994 80.91.229.3 (28 Oct 2015 10:02:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Oct 2015 10:02:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 28 11:01:55 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZrNYI-0001jJ-BY for ged-emacs-devel@m.gmane.org; Wed, 28 Oct 2015 11:01:54 +0100 Original-Received: from localhost ([::1]:36502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrNYH-0001vt-QZ for ged-emacs-devel@m.gmane.org; Wed, 28 Oct 2015 06:01:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrNY1-0001cx-Fd for emacs-devel@gnu.org; Wed, 28 Oct 2015 06:01:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrNXw-0006Ix-M5 for emacs-devel@gnu.org; Wed, 28 Oct 2015 06:01:37 -0400 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:43175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrNXw-0006IF-H9 for emacs-devel@gnu.org; Wed, 28 Oct 2015 06:01:32 -0400 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1ZrNXu-0007n0-Ex; Wed, 28 Oct 2015 10:01:30 +0000 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1ZrNXu-0004ui-C5; Wed, 28 Oct 2015 10:01:30 +0000 In-Reply-To: (Stefan Monnier's message of "Tue, 27 Oct 2015 10:50:47 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192780 Archived-At: Stefan Monnier writes: >> I have noticed one problem case. The *scratch* buffer is created without >> an undo-boundary after the ";;; This buffer is..." message. I think this >> is a bootstrap problem and can be fixed by adding an undo-boundary call >> to startup.el. > > The boundary is supposed to be added just before the first command > (since undo-boundaries are added by the command loop right before > running a command). so maybe the problem is that it doesn't get added > to your list of "buffers with undo elements"? I'm working on this, although it's hard to work out. Is Emacs even in the command loop when it runs startup.el? My inclination would be to just put an explicit "undo-boundary" into startup, as it is more straight-forward than working my way through the emacs boot process. >> Other than this, are these changes ready to go? > > I'll let you know as soon as I find the time to review it, Apologies! I didn't mean to appear to nag. I am quite patient (especially at this time of year). Phil