From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 8726de6: Finish excising electric indent from `open-line' Date: Sun, 22 Nov 2015 00:23:50 -0600 Message-ID: <87io4u362x.fsf@red-bean.com> References: <20151122045054.17266.64677@vcs.savannah.gnu.org> Reply-To: Karl Fogel NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448173454 30420 80.91.229.3 (22 Nov 2015 06:24:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 06:24:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 22 07:24:09 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0O4F-00039B-W1 for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 07:24:08 +0100 Original-Received: from localhost ([::1]:54956 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0O4F-0000Gf-MI for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 01:24:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0O43-0000GG-6f for emacs-devel@gnu.org; Sun, 22 Nov 2015 01:23:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0O40-0004dX-3z for emacs-devel@gnu.org; Sun, 22 Nov 2015 01:23:55 -0500 Original-Received: from mail-ig0-x22f.google.com ([2607:f8b0:4001:c05::22f]:36757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0O3z-0004dT-Uu for emacs-devel@gnu.org; Sun, 22 Nov 2015 01:23:52 -0500 Original-Received: by igcph11 with SMTP id ph11so34430004igc.1 for ; Sat, 21 Nov 2015 22:23:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=GUm8bU4Vu4mONHP6KP7FSjupdZ5ecVUXwmlteVphmqk=; b=ZOPXsp73ocEGLKw/sgnQndZgaKbzbvRnKEy1drm6JOGFZr6W6Iw3J2cNiVgAaCt+pv BX8ddJY5wr9olPqfU3C2SgTFCMe1J7M9ESrZdsXq/NPDSXWXgydgsF3N0APoxOAmptwJ 9KnrrN34AX93G5Jx1AV292sfkcqZSXCCJ7rVRYqEx+G0b81icN8bfFB1jUdk0IepoDAU dbuE9WvYvvHapDtUDX20ON7aKAn1SQLN36c4OvHlhVu7fuNKI8+V9rwRSePNz0SOyL/p 6Kmn3zCTqibwh9HCNs9hZm/LYBdcibB2RxGK9YYjfmtN518y6mP5g207c77lPjHFuLFB qWyA== X-Received: by 10.50.49.46 with SMTP id r14mr8116671ign.71.1448173431335; Sat, 21 Nov 2015 22:23:51 -0800 (PST) Original-Received: from kdesk (24-148-35-36.c3-0.grn-ubr1.chi-grn.il.cable.rcn.com. [24.148.35.36]) by smtp.gmail.com with ESMTPSA id ej5sm3033157igc.2.2015.11.21.22.23.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Nov 2015 22:23:50 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Sun, 22 Nov 2015 00:25:05 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c05::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194989 Archived-At: Stefan Monnier writes: >> * lisp/simple.el (open-line): Remove INTERACTIVE argument. > >Nit pick: the point of this change is to stop passing `interactive' to >`newline'. As a consequence, `interactive' becomes unused so it can be >removed, but the removal of `interactive' is not the crucial element. Thanks for the review, Stefan. Since I explained the overall point of the change elsewhere in the commit message, I deliberately kept a narrower focus in the part of the commit message that's about the diff to `open-line'. However, on reflection, I think you're right that it would have been clearer to say something like this: * lisp/simple.el (open-line): Remove INTERACTIVE flag, so that it is no longer passed to `newline', so that invoking `newline' no longer causes electric indentation to happen. Oh, well. Although mostly pleased with Emacs' transition to distributed version control, I do miss one thing: being able to edit log messages after the fact! Best regards -Karl