From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.devel Subject: Re: Can we not introduce frivolous indentation change to define-minor-mode? Date: Wed, 06 Jan 2016 16:37:57 +0100 Message-ID: <87io36k9be.fsf@bernoul.li> References: <83d1tg57p6.fsf@gnu.org> <87fuybqdby.fsf@gmail.com> <87lh82vq6t.fsf@gmail.com> <87d1tevmjb.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1452094710 27760 80.91.229.3 (6 Jan 2016 15:38:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jan 2016 15:38:30 +0000 (UTC) Cc: Leo Liu , Artur Malabarba , emacs-devel To: Oleh Krehel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 06 16:38:21 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aGqAE-0001Ie-MX for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2016 16:38:19 +0100 Original-Received: from localhost ([::1]:54788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGqAE-0005VY-21 for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2016 10:38:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGqA9-0005VI-S1 for emacs-devel@gnu.org; Wed, 06 Jan 2016 10:38:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGqA4-0003mq-Ni for emacs-devel@gnu.org; Wed, 06 Jan 2016 10:38:13 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]:37583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGqA4-0003li-I4 for emacs-devel@gnu.org; Wed, 06 Jan 2016 10:38:08 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 8C57016DD3; Wed, 6 Jan 2016 16:38:03 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id iSriiKmL-Ydq; Wed, 6 Jan 2016 16:38:03 +0100 (CET) Original-Received: from hal (84-73-67-69.dclient.hispeed.ch [84.73.67.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 1F09A16DC8; Wed, 6 Jan 2016 16:38:03 +0100 (CET) User-agent: mu4e 0.9.15; emacs 25.0.50.1 In-reply-to: <87d1tevmjb.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.243.197.30 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197701 Archived-At: Oleh Krehel writes: > Artur Malabarba writes: > >> What if you set the indent spec to defun? Does that work? > > What do you mean here? The indent spec of `defun' is (indent 2), it's > not justified for `define-minor-mode', The `defun' indent variant should be used, not the indent variant used by `defun'. (I assume the `defun' indent value was originally used by `defun' and got its name that way. But this is (no longer) the case,0 which makes this a bit confusing.) With (defmacro define-minor-mode (...) "..." (declare ... (indent defun)) ...) we get (define-minor-mode foo-mode "doc-string" :global t) and (define-minor-mode foo-mode nil :global t) So everyone can be happy again.