all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jonas Bernoulli <jonas@bernoul.li>
To: Oleh Krehel <ohwoeowho@gmail.com>
Cc: Leo Liu <sdl.web@gmail.com>,
	Artur Malabarba <bruce.connor.am@gmail.com>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: Can we not introduce frivolous indentation change to define-minor-mode?
Date: Wed, 06 Jan 2016 16:37:57 +0100	[thread overview]
Message-ID: <87io36k9be.fsf@bernoul.li> (raw)
In-Reply-To: <87d1tevmjb.fsf@gmail.com>


Oleh Krehel <ohwoeowho@gmail.com> writes:

> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>
>> What if you set the indent spec to defun? Does that work?
>
> What do you mean here? The indent spec of `defun' is (indent 2), it's
> not justified for `define-minor-mode',

The `defun' indent variant should be used, not the indent variant used
by `defun'.  (I assume the `defun' indent value was originally used by
`defun' and got its name that way.  But this is (no longer) the case,0
which makes this a bit confusing.)

With

  (defmacro define-minor-mode (...)
    "..."
    (declare ... (indent defun))
    ...)

we get

  (define-minor-mode foo-mode
    "doc-string"
    :global t)

and

  (define-minor-mode foo-mode nil
    :global t)

So everyone can be happy again.



  parent reply	other threads:[~2016-01-06 15:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 12:32 Can we not introduce frivolous indentation change to define-minor-mode? Leo Liu
2016-01-05 16:09 ` Eli Zaretskii
2016-01-05 23:11   ` Leo Liu
2016-01-06  9:14     ` Oleh Krehel
2016-01-06 11:50       ` Leo Liu
2016-01-06 12:38         ` Oleh Krehel
2016-01-06 13:42           ` Artur Malabarba
2016-01-06 13:56             ` Oleh Krehel
2016-01-06 14:33               ` Artur Malabarba
2016-01-06 15:37               ` Jonas Bernoulli [this message]
2016-01-06 15:48                 ` Oleh Krehel
2016-01-06 15:54                   ` Dmitry Gutov
2016-01-06 16:02                     ` Oleh Krehel
2016-01-07  1:54                       ` Leo Liu
2016-01-07 16:09                         ` Eli Zaretskii
2016-01-07 17:58                           ` John Wiegley
2016-01-07 18:49                             ` Leo Liu
2016-01-07 19:00                               ` John Wiegley
2016-01-07 19:40                                 ` Leo Liu
2016-01-07 19:05                               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io36k9be.fsf@bernoul.li \
    --to=jonas@bernoul.li \
    --cc=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=ohwoeowho@gmail.com \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.