From: phillip.lord@russet.org.uk (Phillip Lord)
To: emacs-devel@gnu.org
Cc: Michael Albinus <michael.albinus@gmx.de>
Subject: Re: [Emacs-diffs] emacs-25 f5c762c: Additional changes for "make check-expensive"
Date: Tue, 12 Jan 2016 17:43:18 +0000 [thread overview]
Message-ID: <87io2y66dl.fsf@russet.org.uk> (raw)
In-Reply-To: <E1aGNHT-0007u5-Su@vcs.savannah.gnu.org> (Michael Albinus's message of "Tue, 5 Jan 2016 08:47:51 +0000")
Michael Albinus <Michael.Albinus@gmx.de> writes:
> diff --git a/test/automated/Makefile.in b/test/automated/Makefile.in
> index 43e3905..48920ef 100644
> --- a/test/automated/Makefile.in
> +++ b/test/automated/Makefile.in
> @@ -87,9 +87,9 @@ WRITE_LOG = > $@ 2>&1 || { stat=ERROR; cat $@; }; echo $$stat: $@
> ## to change this; bug#17848 - if that gets done, this can be simplified).
> ##
> ## Beware: it approximates 'no-byte-compile', so watch out for false-positives!
> -SELECTOR_DEFAULT=(not (tag :expensive-test))
> +SELECTOR_DEFAULT=(quote (not (tag :expensive-test)))
> SELECTOR_EXPENSIVE=nil
> -SELECTOR=${SELECTOR_DEFAULT}
> +SELECTOR=
Michael
I think that there is a problem with this commit, in that the default
selector is only used for "make check". By default "make check-maybe"
runs all tests (including the expensive ones). So, you have to do
make check-maybe SELECTOR="(quote (not (tag :expensive-test)))"
I think it makes more sense for check-maybe to skip expensive tests,
unless told otherwise, as "make check-maybe" is a good candidate for use
pre-commit.
Something like this should work:
SELECTOR_DEFAULT=(quote (not (tag :expensive-test)))
SELECTOR_EXPENSIVE=nil
SELECTOR=
ifeq ($(SELECTOR),undefined)
SELECTOR_ACTUAL=$(SELECTOR_DEFAULT)
else
SELECTOR_ACTUAL=$(SELECTOR)
endif
(and changing all subsequent uses of SELECTOR to SELECTOR_ACTUAL).
which would preserve the use of "SELECTOR" for use on the command line.
Make sense? (er, pun not intended).
Phil
next parent reply other threads:[~2016-01-12 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160105084751.30334.99051@vcs.savannah.gnu.org>
[not found] ` <E1aGNHT-0007u5-Su@vcs.savannah.gnu.org>
2016-01-12 17:43 ` Phillip Lord [this message]
2016-01-12 17:49 ` [Emacs-diffs] emacs-25 f5c762c: Additional changes for "make check-expensive" John Wiegley
2016-01-12 18:55 ` Michael Albinus
2016-01-14 22:15 ` Phillip Lord
2016-01-12 19:03 ` Michael Albinus
2016-01-14 8:13 ` Michael Albinus
2016-01-14 23:04 ` Phillip Lord
2016-01-15 8:45 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io2y66dl.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.