From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22466@debbugs.gnu.org
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Date: Tue, 26 Jan 2016 17:25:36 +0000 [thread overview]
Message-ID: <87io2gns3b.fsf@gmail.com> (raw)
In-Reply-To: <87y4bcsogq.fsf@gmail.com>
Eli Zaretskii <eliz@gnu.org> writes:
> It's not redisplay that does this. It's the fact that disable-theme
> changes the frame's background color, and when that happens, we
> immediately clear the frame using the new background color, as part of
> the modify-frame-parameters call.
>
> Redisplay only handles the portions of display where there's text and
> other decorations that we manage. Clearing the frame with the new
> background color is not redisplay's job.
Thanks, that's good to know.
>> (set-frame-parameter frame 'background-color
>> (custom--frame-color-default
>> frame :background "background" "Background"
>> "unspecified-bg" "white"))
>>
>> I'm not saying this form is wrong. I'm just pointing to where it happens.
>
> What happens if you remove that from disable-theme?
Then there's no flashing, but then if I simply disable the theme
(without enabling a new one) I'm left with theme's background.
> (I don't really understand why it has to specify "white".)
I guess it's meant to reset the face to the default. Although, I don't
see why this is explicitly necessary for the default
background/foreground colors, but isn't necessary for other faces.
> Anyway, how come you get to doing this so often it hurts your eyes?
> Aren't people setting their beloved theme once when the session
> starts, and then never change it?
I never change my main color theme, but I always have a second theme
enabled that only affects the mode-line. This second theme is changed
occasionally and it always causes a flash (even though the theme has
nothing to do with the background).
Besides, custom themes are not just for faces. This also came up because
someone is writing a package that simultaneously toggles between
different values for a set of variables (called a context) using
custom-themes. That's something that's designed to be used a couple
times a day.
Anyway, it's not a huge defficiency and it's not worth any large
efforts. I brought it up because I thought there was an eager redisplay
happening somewhere and that might point to a deeper bug, but you've
clearly explained that's not the case. :-)
next prev parent reply other threads:[~2016-01-26 17:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 9:02 bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash Artur Malabarba
2016-01-26 14:58 ` Eli Zaretskii
2016-01-26 16:36 ` Drew Adams
2016-01-26 17:03 ` Eli Zaretskii
2016-01-26 18:41 ` Michael Albinus
2016-01-26 18:55 ` Eli Zaretskii
2016-01-26 19:31 ` Michael Albinus
[not found] ` <<87y4bc89pt.fsf@gmx.de>
[not found] ` <<834me01881.fsf@gnu.org>
2016-01-26 23:02 ` Drew Adams
2016-01-26 17:25 ` Artur Malabarba [this message]
2016-01-26 20:15 ` Eli Zaretskii
2016-01-27 20:20 ` Artur Malabarba
2016-01-28 3:36 ` Eli Zaretskii
[not found] <<87y4bcsogq.fsf@gmail.com>
[not found] ` <<83powo1j71.fsf@gnu.org>
[not found] ` <<1bbf7218-bd5b-4618-822c-cd75884a81ee@default>
[not found] ` <<83d1so1df3.fsf@gnu.org>
2016-01-26 17:07 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io2gns3b.fsf@gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=22466@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.