Re: org-attach-commit optional

[John J Foerch <jjfoerch@earthlink.net>]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> John J Foerch <jjfoerch@earthlink.net> writes:
>
>> I would like for org-attach's automatic committing of attachments to be
>> easily disabled.  Something along the lines of the attached patch.
>> Thoughts?
>
> Thank you. A few stylistic comments follow.
>
>> Subject: [PATCH] org-attach-attach: make use of git optional with variable
>>  org-attach-commit
>
> The commit message should be something along the lines:
>
>   org-attach: Optionally make use of git
>
> * lisp/org-attach.el (org-attach-commit): New variable.
> (org-attach-attach): Use new variable.
>
> You also need to add TINYCHANGE at the end of the commit message. On
> this topic, please not that you are, with this patch, reaching the limit
> of allowed changes without FSF assignment. You may want to consider
> signing FSF papers.
>
>> +(defcustom org-attach-commit t
>> +  "If non-nil, attachments will be committed with git, if the org
>> +file is in a git repository."
>> +  :group 'org-attach
>> +  :type 'boolean)
>
> First line in docstring should be a sentence on its own, e.g.
>
>     "Non-nil means attachements are to be committed with git.
>   This can only happen if the Org file is in a git repository."
>
> You should also add :version and :package-version keywords, e.g.,
>
>   :version "25.1"
>   :package-version '(Org . "9.0")
>
>
> Regards,

Many thanks, Nicolas,

I would be glad to do the paperwork, but as it's such a simple change, I
have no objections to anybody else implementing this feature request in
my place if they want to.  I think it would save time.  Need not use the
patch I sent, which needs revision anyway - it was just a suggested
implementation.  Let me know if this works for this community, or
whether it is preferred for me to go through the FSF process.

Thank you,

John Foerch