bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation

bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation

[Magnus Henoch]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]


Severity: minor
Tags: patch

The input method polish-slash is the only input method in latin-pre.el
that passes t as the KBD-TRANSLATE argument to quail-define-package.  I
think it shouldn't do that, because it doesn't represent an alternative
keyboard layout; it's just a thin layer over whatever keyboard layout is
currently in use.

This patch changes the KBD-TRANSLATE argument to nil:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 517 bytes --]

diff --git a/lisp/leim/quail/latin-pre.el b/lisp/leim/quail/latin-pre.el
index 6202b89..b3a7591 100644
--- a/lisp/leim/quail/latin-pre.el
+++ b/lisp/leim/quail/latin-pre.el
@@ -707,7 +707,7 @@ Key translation rules are:
  "polish-slash" "Polish" "PL>" nil
  "Polish diacritics and slash character are input as `/[acelnosxzACELNOSXZ/]'.
 For example, the character named `aogonek' is obtained by `/a'."
- nil t t t nil nil nil nil nil nil t)
+ nil t t nil nil nil nil nil nil nil t)
 
 (quail-define-rules
  ("//" ?/)

[-- Attachment #3: Type: text/plain, Size: 17 bytes --]


Regards,
Magnus

bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation

[Lars Ingebrigtsen]

Magnus Henoch <magnus.henoch@gmail.com> writes:

> The input method polish-slash is the only input method in latin-pre.el
> that passes t as the KBD-TRANSLATE argument to quail-define-package.  I
> think it shouldn't do that, because it doesn't represent an alternative
> keyboard layout; it's just a thin layer over whatever keyboard layout is
> currently in use.
>
> This patch changes the KBD-TRANSLATE argument to nil:
>
> diff --git a/lisp/leim/quail/latin-pre.el b/lisp/leim/quail/latin-pre.el
> index 6202b89..b3a7591 100644
> --- a/lisp/leim/quail/latin-pre.el
> +++ b/lisp/leim/quail/latin-pre.el
> @@ -707,7 +707,7 @@ Key translation rules are:
>   "polish-slash" "Polish" "PL>" nil
>   "Polish diacritics and slash character are input as `/[acelnosxzACELNOSXZ/]'.
>  For example, the character named `aogonek' is obtained by `/a'."
> - nil t t t nil nil nil nil nil nil t)
> + nil t t nil nil nil nil nil nil nil t)

I think this sounds reasonable, but I'm not familiar with the quail
functions at all.  Could somebody have a peek at this?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 23 Feb 2016 23:00:28 +1100
> Cc: 19081@debbugs.gnu.org
> 
> Magnus Henoch <magnus.henoch@gmail.com> writes:
> 
> > The input method polish-slash is the only input method in latin-pre.el
> > that passes t as the KBD-TRANSLATE argument to quail-define-package.  I
> > think it shouldn't do that, because it doesn't represent an alternative
> > keyboard layout; it's just a thin layer over whatever keyboard layout is
> > currently in use.
> >
> > This patch changes the KBD-TRANSLATE argument to nil:
> >
> > diff --git a/lisp/leim/quail/latin-pre.el b/lisp/leim/quail/latin-pre.el
> > index 6202b89..b3a7591 100644
> > --- a/lisp/leim/quail/latin-pre.el
> > +++ b/lisp/leim/quail/latin-pre.el
> > @@ -707,7 +707,7 @@ Key translation rules are:
> >   "polish-slash" "Polish" "PL>" nil
> >   "Polish diacritics and slash character are input as `/[acelnosxzACELNOSXZ/]'.
> >  For example, the character named `aogonek' is obtained by `/a'."
> > - nil t t t nil nil nil nil nil nil t)
> > + nil t t nil nil nil nil nil nil nil t)
> 
> I think this sounds reasonable, but I'm not familiar with the quail
> functions at all.  Could somebody have a peek at this?

I hope Handa-san (CC'ed) could comment on this.

bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation

[handa]

In article <87lh6bprfn.fsf@gnus.org>, Lars Ingebrigtsen <larsi@gnus.org> writes:

> Magnus Henoch <magnus.henoch@gmail.com> writes:
> > The input method polish-slash is the only input method in latin-pre.el
> > that passes t as the KBD-TRANSLATE argument to quail-define-package.  I
> > think it shouldn't do that, because it doesn't represent an alternative
> > keyboard layout; it's just a thin layer over whatever keyboard layout is
> > currently in use.

You are right.  The docstring of polish-slash clearly says that typing
"/a" should produce "ą" whereever "/" and "a" are located on a keyboard.
So KBD-TRANSLATE should be nil.

---
K. Handa
handa@gnu.org

bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation

[Lars Ingebrigtsen]

handa <handa@gnu.org> writes:

> In article <87lh6bprfn.fsf@gnus.org>, Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Magnus Henoch <magnus.henoch@gmail.com> writes:
>> > The input method polish-slash is the only input method in latin-pre.el
>> > that passes t as the KBD-TRANSLATE argument to quail-define-package.  I
>> > think it shouldn't do that, because it doesn't represent an alternative
>> > keyboard layout; it's just a thin layer over whatever keyboard layout is
>> > currently in use.
>
> You are right.  The docstring of polish-slash clearly says that typing
> "/a" should produce "ą" whereever "/" and "a" are located on a keyboard.
> So KBD-TRANSLATE should be nil.

Thanks; I've now applied the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no