From: Nicolas Petton <nicolas@petton.fr>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Upcoming seq.el version problem with the Emacs release
Date: Mon, 21 Mar 2016 14:45:27 +0100 [thread overview]
Message-ID: <87io0g0wso.fsf@petton.fr> (raw)
In-Reply-To: <jwvmvpsx8yr.fsf-monnier+gmane.emacs.devel@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> The problem is that seq.el (in Emacs) uses `pcase-defmacro', which does
>> not exist in Emacs 24.5. When byte-compiling the file, we get warnings
>> as the byte compiler will think that `pcase-defmacro' is a function.
>
> Is that really the only problem?
We'd get byte-compilation warnings. Maybe that's something we can live
with, but since it's easy enough to fix, now that I know how to do it,
I'd rather make sure that we don't get any warning in Emacs 24.5.
> I thought the main problem was that GNU ELPA's seq.el can't use
> cl-defgeneric since GNU-ELPA's cl-generic can only dispatch on
> EIEIO types.
No, that's a limitation I'm ok with.
> As for preventing byte-compilation, yes indeed you can and I've done
> that a few times recently. See for example dts--using-macro in the
> dts-mode package (in GNU ELPA).
> See also TeX--if-macro-fboundp in auctex's tex.el.
Thanks for the pointers!
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
prev parent reply other threads:[~2016-03-21 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 13:32 Upcoming seq.el version problem with the Emacs release Nicolas Petton
2016-02-20 6:24 ` John Wiegley
2016-02-20 18:30 ` Nicolas Petton
2016-03-15 21:46 ` Nicolas Petton
2016-03-19 17:44 ` Bozhidar Batsov
2016-03-20 10:15 ` Nicolas Petton
2016-03-20 14:20 ` Bozhidar Batsov
2016-03-20 20:35 ` Michael Heerdegen
2016-03-21 8:39 ` Nicolas Petton
2016-03-21 13:33 ` Stefan Monnier
2016-03-21 13:45 ` Nicolas Petton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io0g0wso.fsf@petton.fr \
--to=nicolas@petton.fr \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.