From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?=C3=93scar?= Fuentes Newsgroups: gmane.emacs.bugs Subject: bug#23785: Emacs 25: "Undo" overdoes things. Date: Fri, 17 Jun 2016 23:49:52 +0200 Message-ID: <87inx7iiyn.fsf@wanadoo.es> References: <20160617150245.GB3316@acm.fritz.box> <83r3bvbuu1.fsf@gnu.org> <20160617174535.GD3316@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466200288 2998 80.91.229.3 (17 Jun 2016 21:51:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jun 2016 21:51:28 +0000 (UTC) Cc: 23785@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 17 23:51:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bE1fX-000372-8i for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 23:51:15 +0200 Original-Received: from localhost ([::1]:60412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE1fW-00056Q-92 for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 17:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE1fQ-00055J-F2 for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 17:51:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bE1fK-0006FP-FR for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 17:51:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE1fK-0006FI-Ct for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 17:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bE1fK-0000aq-7t for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 17:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jun 2016 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23785-submit@debbugs.gnu.org id=B23785.14662002022211 (code B ref 23785); Fri, 17 Jun 2016 21:51:02 +0000 Original-Received: (at 23785) by debbugs.gnu.org; 17 Jun 2016 21:50:02 +0000 Original-Received: from localhost ([127.0.0.1]:44566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE1eM-0000ZY-3g for submit@debbugs.gnu.org; Fri, 17 Jun 2016 17:50:02 -0400 Original-Received: from smtp21.acens.net ([86.109.99.145]:57031 helo=smtp.movistar.es) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE1eK-0000Z0-FN for 23785@debbugs.gnu.org; Fri, 17 Jun 2016 17:50:01 -0400 X-CTCH-RefID: str=0001.0A0B0207.57647081.00A8, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Original-Received: from qcore (217.125.182.141) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 574060E70161AAF6; Fri, 17 Jun 2016 21:49:53 +0000 In-Reply-To: <20160617174535.GD3316@acm.fritz.box> (Alan Mackenzie's message of "Fri, 17 Jun 2016 17:45:35 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119700 Archived-At: Alan Mackenzie writes: > I don't think it's all that minor an issue. `undo' can no longer be > depended upon to restore a buffer to its unchanged state. > > I've suffered several similar annoyances with `undo' in the emacs-25 > branch. Me too, although I'm not sure about Emacs being the culprit. I use Evil and it adds some heuristics on top of Emacs'. > Each buffer changing command is meant to have its own undo boundary > (with the exception of self-insert-command and the single character > deleting command). > > And having to undo/redo command sequences by hand is _very_ irritating > when testing. Only when testing? :-) I've observed cases where sequences of char inserts were undone one at a time and cases where entire edit sessions across multiple areas of the file vanished with one `undo'. > I think there's a case to be made for fixing this bug for Emacs 25.1. FWIW, this is the change that enabled keeping the undo log after revert-buffer (a feature I asked for, BTW): commit 22513e526eba97bd1014e4bacde0a8649fbe7870 Author: Stefan Monnier Date: Tue May 28 21:07:53 2013 -0400 * src/fileio.c (Finsert_file_contents): Preserve undo info when reverting a buffer. Fixes: debbugs:8447