From: Ivan Shmakov <ivan@siamics.net>
To: 24274@debbugs.gnu.org
Cc: Viktor Slavkovik <viktor.slavkovik@gmail.com>, zhtvk@gmx.com
Subject: bug#24274: 24.5; Use auth-source library for remote passwords in Rmail
Date: Sun, 21 Aug 2016 19:30:43 +0000 [thread overview]
Message-ID: <87inutsyvw.fsf@violet.siamics.net> (raw)
In-Reply-To: <87a8g6nqp4.fsf@gmail.com> (Viktor Slavkovik's message of "Sun, 21 Aug 2016 16:26:31 +0200")
>>>>> Viktor Slavkovik <viktor.slavkovik@gmail.com> writes:
>>>>> Ivan Shmakov <ivan@siamics.net> writes:
[…]
>> The auth-source-search function will prompt for password
>> automatically if given ‘:create t’ among its parameters, making
>> explicit read-passwd unnecessary. (But check also the
>> auth-source-creation-prompts variable.)
[…]
> I've made an update (attached) to the previous patch. I removed the
> code indentation spaces and changed the docstring to be more
> descriptive. Also, I included a function check for the auth-source
> password which was missing before.
> ! (if found
> ! (progn
> ! (setq secret (plist-get found :secret))
> ! (if (functionp secret)
> ! (funcall secret)))
There, rmail-remote-password will end up being set to nil if
‘secret’ is /not/ a function. Compare:
(progn
(setq secret (plist-get found :secret))
(if (functionp secret)
(funcall secret)
secret))
> I don't think that the ':create' parameter of auth-source-search
> should be used here, since we don't know if the authentication will
> be successful.
We can call auth-source-forget+ if necessary once we figure it
out; just like it’s done in gnus/nnimap.el and mail/smtpmail.el.
> Content-Type: application/octet-stream
I’d appreciate for the patches to come marked as something
text/*, so that MIME-aware mail user agents could just display
them (as opposed to: ask user to save one into a file.) I guess
that such a Content-Type: will be emitted automatically when the
filename of the file being attached ends with .diff or .patch.
> Content-Disposition: attachment; filename=patch_update
> Content-Transfer-Encoding: base64
> Content-Description: updated patch
--
FSF associate member #7257 http://am-1.org/~ivan/ … 3013 B6A0 230E 334A
next prev parent reply other threads:[~2016-08-21 19:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-20 18:12 bug#24274: 24.5; Use auth-source library for remote passwords in Rmail Viktor Slavkovikj
2016-08-20 19:45 ` Ivan Shmakov
2016-08-21 14:26 ` Viktor Slavkovik
2016-08-21 19:30 ` Ivan Shmakov [this message]
2016-08-22 13:00 ` Ted Zlatanov
2019-06-25 11:54 ` Lars Ingebrigtsen
2020-08-11 14:12 ` Lars Ingebrigtsen
2020-09-07 15:29 ` Antoine Kalmbach
2020-09-07 15:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inutsyvw.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=24274@debbugs.gnu.org \
--cc=viktor.slavkovik@gmail.com \
--cc=zhtvk@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.