From: Alex <agrambot@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 24766@debbugs.gnu.org
Subject: bug#24766: 26.0.50: [PATCH] Confusing behaviour for indent-relative-maybe
Date: Mon, 24 Oct 2016 13:27:43 -0600 [thread overview]
Message-ID: <87insh4keo.fsf@gmail.com> (raw)
In-Reply-To: <837f8y5f5x.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Oct 2016 11:23:22 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Alex <agrambot@gmail.com>
>> Cc: 24766@debbugs.gnu.org
>> Date: Sun, 23 Oct 2016 14:43:57 -0600
>>
>> What about changing `indent-relative-maybe' and adding an extra argument
>> to `indent-relative'? Since `indent-relative-maybe' has had that
>> docstring for a good 15 years, and the name fits the new behaviour more.
>>
>> Then in Emacs core we can replace the single instance of it with
>> (indent-relative t). The corresponding diff:
>
> I'd prefer a backward-compatible change, i.e. make the new argument be
> the 2nd one, and keep the current behavior when the 1st arg is non-nil
> and the 2nd is nil or omitted.
That's what I did, but I used a new name for the old argument and the
old name for the new argument. I did so as the old name fits the new
behaviour more.
This is a backward-compatible change for indent-relative, but it does
use the new behaviour for indent-relative-maybe. Is that alright with
you?
> Also, please add the necessary text to the doc string to document the
> new argument.
Sure, I'll do that once the code changes are agreed upon.
> Thanks.
next prev parent reply other threads:[~2016-10-24 19:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 19:01 bug#24766: 26.0.50: [PATCH] Confusing behaviour for indent-relative-maybe Alex
2016-10-22 19:21 ` Eli Zaretskii
2016-10-22 19:40 ` Alex
2016-10-22 19:48 ` Eli Zaretskii
2016-10-22 21:49 ` Alex
2016-10-23 6:23 ` Eli Zaretskii
2016-10-23 20:43 ` Alex
2016-10-24 8:23 ` Eli Zaretskii
2016-10-24 19:27 ` Alex [this message]
2016-10-24 19:57 ` Eli Zaretskii
2016-11-08 1:53 ` Alex
2016-11-08 15:07 ` Eli Zaretskii
2016-11-08 19:09 ` Alex
2016-11-08 20:26 ` Eli Zaretskii
2016-11-18 9:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87insh4keo.fsf@gmail.com \
--to=agrambot@gmail.com \
--cc=24766@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.