From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: master 39f0543 1/2: vc-git-print-log: pass "--follow" to "log" to handle renamed files Date: Tue, 15 Nov 2016 01:44:53 +0100 Message-ID: <87inrpa7wa.fsf@wanadoo.es> References: <20161115001349.10574.64519@vcs.savannah.gnu.org> <20161115001349.628D2220171@vcs.savannah.gnu.org> <87shqta92v.fsf@wanadoo.es> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1479170735 18224 195.159.176.226 (15 Nov 2016 00:45:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 15 Nov 2016 00:45:35 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: Sam Steingold , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 15 01:45:32 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6Rs2-0000uH-Im for ged-emacs-devel@m.gmane.org; Tue, 15 Nov 2016 01:45:06 +0100 Original-Received: from localhost ([::1]:43407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6Rs5-0005zi-MM for ged-emacs-devel@m.gmane.org; Mon, 14 Nov 2016 19:45:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6Rrw-0005zQ-DC for emacs-devel@gnu.org; Mon, 14 Nov 2016 19:45:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6Rrs-00054c-Eq for emacs-devel@gnu.org; Mon, 14 Nov 2016 19:45:00 -0500 Original-Received: from relaycp04.dominioabsoluto.net ([217.116.26.100]:48395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6Rrs-000547-81; Mon, 14 Nov 2016 19:44:56 -0500 Original-Received: from smtp.movistar.es (smtp22.acens.net [86.109.99.146]) by relaycp04.dominioabsoluto.net (Postfix) with ESMTP id 79CBC6417E; Tue, 15 Nov 2016 01:44:54 +0100 (CET) X-CTCH-RefID: str=0001.0A0B0203.582A5A86.0058, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Original-Received: from qcore (83.35.188.160) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 57A446BD0537CBBB; Tue, 15 Nov 2016 00:44:50 +0000 In-Reply-To: (Sam Steingold's message of "Mon, 14 Nov 2016 19:24:25 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 217.116.26.100 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209408 Archived-At: Sam Steingold writes: > No, I was not - until now. > I used the change for a month before committing it and was pretty happy. > I will revert the commit and add a comment. > Sorry. Thanks. I was aware of the removal of --follow because I wanted it there too :-) Apart from the problem described on the bug report, IIRC other people mentioned that it makes the command significantly slower, so it is not a good candidate as a default. Maybe we can test for the presence of --follow and remove it from the git command when the target is a directory?