Re: master 39f0543 1/2: vc-git-print-log: pass "--follow" to "log" to handle renamed files

Re: master 39f0543 1/2: vc-git-print-log: pass "--follow" to "log" to handle renamed files

[Óscar Fuentes]

sds@gnu.org (Sam Steingold) writes:

> branch: master
> commit 39f0543ca18142f318a1c90f100632c49a000a1c
> Author: Sam Steingold <sds@gnu.org>
> Commit: Sam Steingold <sds@gnu.org>
>
>     vc-git-print-log: pass "--follow" to "log" to handle renamed files

Are you aware of

commit 85a5f61f29516b4e3fa132976e8ea07f76d11cf1
Author: Glenn Morris <rgm@gnu.org>
Date:   Tue Jan 21 21:01:40 2014 -0500

    * lisp/vc/vc-git.el (vc-git-print-log): Remove --follow;
    reverts 2014-01-09 change.
    
    Fixes: debbugs:16422

?

Re: master 39f0543 1/2: vc-git-print-log: pass "--follow" to "log" to handle renamed files

[Sam Steingold]

No, I was not - until now.
I used the change for a month before committing it and was pretty happy.
I will revert the commit and add a comment.
Sorry.

On Mon, Nov 14, 2016 at 7:19 PM, Óscar Fuentes <ofv@wanadoo.es> wrote:
> sds@gnu.org (Sam Steingold) writes:
>
>> branch: master
>> commit 39f0543ca18142f318a1c90f100632c49a000a1c
>> Author: Sam Steingold <sds@gnu.org>
>> Commit: Sam Steingold <sds@gnu.org>
>>
>>     vc-git-print-log: pass "--follow" to "log" to handle renamed files
>
> Are you aware of
>
> commit 85a5f61f29516b4e3fa132976e8ea07f76d11cf1
> Author: Glenn Morris <rgm@gnu.org>
> Date:   Tue Jan 21 21:01:40 2014 -0500
>
>     * lisp/vc/vc-git.el (vc-git-print-log): Remove --follow;
>     reverts 2014-01-09 change.
>
>     Fixes: debbugs:16422
>
> ?



-- 
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>

Re: master 39f0543 1/2: vc-git-print-log: pass "--follow" to "log" to handle renamed files

[Óscar Fuentes]

Sam Steingold <sds@gnu.org> writes:

> No, I was not - until now.
> I used the change for a month before committing it and was pretty happy.
> I will revert the commit and add a comment.
> Sorry.

Thanks.

I was aware of the removal of --follow because I wanted it there too :-)

Apart from the problem described on the bug report, IIRC other people
mentioned that it makes the command significantly slower, so it is not a
good candidate as a default.

Maybe we can test for the presence of --follow and remove it from the
git command when the target is a directory?