From: Hong Xu <hong@topbug.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 25022@debbugs.gnu.org
Subject: bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
Date: Tue, 06 Dec 2016 11:57:27 -0800 [thread overview]
Message-ID: <87inqwespk.fsf@topbug.net> (raw)
In-Reply-To: <m3zik95a4y.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On 2016-12-06 Tue 07:51 GMT-0800, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> If you change the condition to be true for any mode derived from
>> message-mode, then all of them will inherit this feature. Are we sure
>> those other modes all want that? For example, gnus-art.el defines one
>> such mode; up until now, that mode didn't use this feature, maybe that
>> was for a good reason?
>
> No, I don't think that was on purpose. I probably just didn't know
> about derived-mode-p at the time...
I've already proposed the one-line change in #25124. You can commit
directly since this is just one line...
I saw a comment "FIXME: use derived-mode-p" but I'm not sure why it
wasn't changed directly on the code itself.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-12-06 19:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 23:22 bug#25022: 25.1.50; Different highlighting for different citation level in message-mode Hong Xu
2016-12-06 6:08 ` Hong Xu
2016-12-06 7:39 ` Katsumi Yamaoka
2016-12-06 8:52 ` Hong Xu
2016-12-06 10:08 ` Katsumi Yamaoka
2019-06-24 23:30 ` Lars Ingebrigtsen
2016-12-06 9:17 ` Hong Xu
2016-12-06 15:31 ` Eli Zaretskii
2016-12-06 15:51 ` Lars Ingebrigtsen
2016-12-06 19:57 ` Hong Xu [this message]
2016-12-06 20:04 ` Hong Xu
2019-09-23 11:12 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inqwespk.fsf@topbug.net \
--to=hong@topbug.net \
--cc=25022@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.