From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#25525: 25.1.90; add color highlighting to css mode Date: Wed, 25 Jan 2017 10:25:21 -0700 Message-ID: <87inp3gigu.fsf@tromey.com> References: <87mvefh8br.fsf@tromey.com> <83inp32l50.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485365226 16384 195.159.176.226 (25 Jan 2017 17:27:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 25 Jan 2017 17:27:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) Cc: 25525@debbugs.gnu.org, Tom Tromey To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 25 18:27:02 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWRLK-0002oG-RD for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jan 2017 18:26:47 +0100 Original-Received: from localhost ([::1]:33325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWRLP-000874-To for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jan 2017 12:26:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWRKf-0007Ij-RD for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 12:26:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWRKc-0000YE-NV for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 12:26:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWRKc-0000Y3-Jm for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 12:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cWRKc-0003QQ-CR for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 12:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2017 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25525-submit@debbugs.gnu.org id=B25525.148536514513140 (code B ref 25525); Wed, 25 Jan 2017 17:26:02 +0000 Original-Received: (at 25525) by debbugs.gnu.org; 25 Jan 2017 17:25:45 +0000 Original-Received: from localhost ([127.0.0.1]:43179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWRKL-0003Ps-89 for submit@debbugs.gnu.org; Wed, 25 Jan 2017 12:25:45 -0500 Original-Received: from gproxy1-pub.mail.unifiedlayer.com ([69.89.25.95]:49416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWRKI-0003Pd-Rf for 25525@debbugs.gnu.org; Wed, 25 Jan 2017 12:25:43 -0500 Original-Received: from cmgw2 (cmgw3 [10.0.90.83]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 8D8E617633D for <25525@debbugs.gnu.org>; Wed, 25 Jan 2017 10:25:30 -0700 (MST) Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id chRQ1u00S2f2jeq01hRTM9; Wed, 25 Jan 2017 10:25:28 -0700 X-Authority-Analysis: v=2.1 cv=ZINExxLb c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=mDV3o1hIAAAA:8 a=zmvBgvANYKEz0gEvOrwA:9 a=_FVE-zBwftR9WsbkzFJk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jZz9JfNy9y5+y81DricJ4G+PenuXfdW836X7RKG8tP8=; b=a9MixCkSrI9v6QXFvE45Ejc3C5 3AjMOGaEtY7wen8YhTmMCocDrGYmlbOzx/vDnN1ukECPel52FMmNco7JgOmdN+4lMb9crFSJAUVm8 8/uBHizCVO2DhK6AFTyiYftxJ; Original-Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:50494 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cWRK1-0003gj-VD; Wed, 25 Jan 2017 10:25:26 -0700 X-Attribution: Tom In-Reply-To: <83inp32l50.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 25 Jan 2017 17:51:23 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cWRK1-0003gj-VD X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (bapiya) [174.16.146.181]:50494 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128469 Archived-At: >>>>> "Eli" == Eli Zaretskii writes: Eli> For example, tty-colors.el already has a (longer) list of colors with Eli> suitable RGB values, so perhaps we should simply add the few missing Eli> ones to that list, and then use that for CSS? CSS specifies the named colors that are available -- so the list in tty-colors.el would not be correct. Eli> As another example, tty-colors.el also includes code for parsing and Eli> converting color values (although perhaps not all of the formats you Eli> support in your code). Here too the new code supports what CSS specifies. It's important to the CSS developer that the Emacs mode follow CSS as precisely as possible; using other formats supplied by tty-colors.el would result in code that is invalid CSS. I think the only area of overlap is the #RRGGBB hex syntax, but that is so trivial as not to need any sharing. Eli> As yet another example of existing functionality that you could Eli> perhaps reuse, there's the :distant-foreground attribute of a face Eli> that might help you with the issue of color contrast. It seemed simpler to always set the :foreground, but I can experiment with :distant-foreground instead. Tom