all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: 25618@debbugs.gnu.org
Subject: bug#25618: 25.1.91; More precise limit for tagging expensive tests
Date: Sat, 04 Feb 2017 22:42:44 +0900	[thread overview]
Message-ID: <87inoqqdgr.fsf@calancha-pc> (raw)


Prefer set a numeric limit of seconds than using the word 'few'.

For instance, in my box the test `cl-seq-test-bug24264' in
test/lisp/emacs-lisp/cl-seq-tests.el
takes 7 s.
With an explicit numeric threshold is easier to decide whether this test
must be tagged as expensive or not.

In following patch i define a few as 2-3 seconds.  Other people might
prefer 4-5 or even higher.
Please, suggest a proper value to consider a test as expensive.

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
From 5671609ff5120ac7572b8a103a9aeb899542d47f Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha@gmail.com>
Date: Sat, 4 Feb 2017 22:29:24 +0900
Subject: [PATCH] More precise limit for tagging expensive tests

* CONTRIBUTE (Testing your changes): Tag a test as expensive
when lasts longer than 2-3 seconds.
---
 CONTRIBUTE | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CONTRIBUTE b/CONTRIBUTE
index e9a0341980..155b7ef762 100644
--- a/CONTRIBUTE
+++ b/CONTRIBUTE
@@ -273,7 +273,7 @@ http://www.gnu.org/software/emacs/manual/html_node/ert/
 or run 'info "(ert)"' for for more information on writing and running
 tests.
 
-If your test lasts longer than some few seconds, mark it in its
+If your test lasts longer than 2-3 seconds, mark it in its
 'ert-deftest' definition with ":tags '(:expensive-test)".
 
 To run tests on the entire Emacs tree, run "make check" from the
-- 
2.11.0

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
In GNU Emacs 25.1.91.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.7)
 of 2017-02-04
Repository revision: 5e921112680f96d3ed94faf7dcf257e07f92d74b





             reply	other threads:[~2017-02-04 13:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-04 13:42 Tino Calancha [this message]
2017-02-04 14:01 ` bug#25618: 25.1.91; More precise limit for tagging expensive tests Noam Postavsky
2017-02-04 14:13   ` Tino Calancha
2017-02-04 16:50 ` Eli Zaretskii
2017-02-04 17:54   ` Tino Calancha
2017-02-10  8:49     ` Eli Zaretskii
2017-02-10  9:28       ` Tino Calancha
2017-02-05  9:53   ` Michael Albinus
2017-02-05 13:53     ` Noam Postavsky
2017-02-05 15:35 ` bug#25618: AW: " michael.albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inoqqdgr.fsf@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=25618@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.