all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Zhitao Gong <zhitaao.gong@gmail.com>
To: emacs-orgmode@gnu.org
Subject: About org-sort -> org-sort-list with custom sort function
Date: Wed, 03 May 2017 14:36:52 -0500	[thread overview]
Message-ID: <87inlhhgvf.fsf@gmail.com> (raw)

Hi All,

I think there is a bug in org-sort or org-sort-list function.

If you call org-sort (C-c ^) on list items, this function will call
org-sort-list.  However, org-sort calls org-sort-list with only one
argument, i.e., the with-case (see the code below)

#+BEGIN_SRC emacs-lisp
((org-at-item-p) (org-call-with-arg 'org-sort-list with-case))
#+END_SRC emacs-lisp

The problem is that if you choose ?f (sorting with custom key function),
then org-sort-list expects another argument, the compare-func, which is
not passed to it.

IMHO, there are two ways to solve this

1. Ask for the compare-func in org-sort-list, as it does for the
   getkey-func.  A default value could be provided for compare-func,
   e.g., string<, <, etc.  Or
2. Restrict the return type to a string (or integer) so that we could
   fix the compare-func

-- 
gongzhitaao / 半緣脩道半緣君

             reply	other threads:[~2017-05-03 19:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 19:36 Zhitao Gong [this message]
2017-05-07  2:55 ` About org-sort -> org-sort-list with custom sort function Kyle Meyer
2017-05-07 10:00   ` Nicolas Goaziou
2017-05-07 14:20     ` Kyle Meyer
2017-05-07 15:37       ` Kyle Meyer
2017-05-08  9:48         ` Nicolas Goaziou
2017-05-08 15:24           ` Kyle Meyer
2017-05-08 16:23             ` Nicolas Goaziou
2017-05-08 16:45               ` Kyle Meyer
2017-05-08 16:48                 ` Nicolas Goaziou
2017-05-09 19:47                 ` [PATCH] org-sort: Read compare-func in interactive calls Kyle Meyer
2017-05-11 21:47                   ` Nicolas Goaziou
2017-05-12  1:48                     ` Kyle Meyer
2017-05-12  7:10                       ` Nicolas Goaziou
2017-05-13 14:50                         ` [PATCH v2] " Kyle Meyer
2017-05-14  8:24                           ` Nicolas Goaziou
2017-05-14 13:45                             ` Kyle Meyer
2017-05-14 16:51                               ` Nicolas Goaziou
2017-05-14 20:54                                 ` Kyle Meyer
2017-05-17 12:32                                   ` Nicolas Goaziou
2017-05-09  4:10             ` About org-sort -> org-sort-list with custom sort function Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inlhhgvf.fsf@gmail.com \
    --to=zhitaao.gong@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.