From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.bugs Subject: bug#21072: Brave new mark-defun (and a testing tool) Date: Fri, 12 May 2017 11:42:24 +0200 Message-ID: <87inl61ke7.fsf@jane> References: <87o9ydrzkr.fsf@mbork.pl> <87bmu2eoji.fsf@jane> <87wpcpw61w.fsf@jane> <83o9xdghmc.fsf@gnu.org> <87o9wkoald.fsf@jane> <87a881ofsu.fsf@jane> <87k272wh8x.fsf@users.sourceforge.net> <871st4aal7.fsf@jane> <87tw5l7v26.fsf@jane> <877f2hs1nw.fsf@users.sourceforge.net> <87zifa9ce5.fsf@jane> <87shl0pbcg.fsf@users.sourceforge.net> <87shky9ez8.fsf@jane> <8737cyotmt.fsf@users.sourceforge.net> <87h919yf5g.fsf@jane> <87efvygq6q.fsf@jane> <87pofhjubv.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1494582133 30521 195.159.176.226 (12 May 2017 09:42:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 12 May 2017 09:42:13 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 26.0.50 Cc: 21072@debbugs.gnu.org, Stefan Monnier To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 12 11:42:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d975L-0007lS-RR for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 May 2017 11:42:07 +0200 Original-Received: from localhost ([::1]:52332 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d975R-0004Sj-IW for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 May 2017 05:42:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d975K-0004Ot-QE for bug-gnu-emacs@gnu.org; Fri, 12 May 2017 05:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d975G-0004g6-Rs for bug-gnu-emacs@gnu.org; Fri, 12 May 2017 05:42:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37057) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d975G-0004fz-Om for bug-gnu-emacs@gnu.org; Fri, 12 May 2017 05:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d975G-0002CW-5N for bug-gnu-emacs@gnu.org; Fri, 12 May 2017 05:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Marcin Borkowski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2017 09:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21072-submit@debbugs.gnu.org id=B21072.14945821048435 (code B ref 21072); Fri, 12 May 2017 09:42:02 +0000 Original-Received: (at 21072) by debbugs.gnu.org; 12 May 2017 09:41:44 +0000 Original-Received: from localhost ([127.0.0.1]:39734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d974x-0002Bz-Vx for submit@debbugs.gnu.org; Fri, 12 May 2017 05:41:44 -0400 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:37091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d974u-0002Bl-27 for 21072@debbugs.gnu.org; Fri, 12 May 2017 05:41:40 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 2A2CDE6488; Fri, 12 May 2017 11:41:38 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VL4e_ba9jmhr; Fri, 12 May 2017 11:41:33 +0200 (CEST) Original-Received: from localhost (unknown [83.13.149.242]) by mail.mojserwer.eu (Postfix) with ESMTPSA id B5840E6049; Fri, 12 May 2017 11:41:31 +0200 (CEST) In-reply-to: <87pofhjubv.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132459 Archived-At: On 2017-05-10, at 04:53, npostavs@users.sourceforge.net wrote: > Marcin Borkowski writes: > >> I finally found some time to make the branch nicer, deleted it from the >> server and pushed the new one. Could you look at it one more time and >> merge it to master (or greenlight me to do it)? > > [[c1c3403cf2]] >> Fix Bug#21072 and rework `mark-defun' >> >> * test/lisp/progmodes/elisp-mode-tests.el (mark-defun-test-buffer): >> New variable >> (mark-defun-no-arg-region-inactive) >> (mark-defun-no-arg-region-active) >> (mark-defun-arg-region-active) >> (mark-defun-pos-arg-region-inactive) > > There should be a colon after the close paren on each of those lines. > >> (mark-defun-neg-arg-region-inactive, mark-defun-bob): Add tests for >> the new `mark-defun' >> >> * lisp/emacs-lisp/lisp.el (beginning-of-defun--in-emptyish-line-p): >> New function >> (beginning-of-defun-comments): New function >> (mark-defun): Fix bug#21072, also rewrite large parts of `mark-defun' >> to accept a numerical prefix argument > > There should be a period at the end of each entry. > > [[aeed45da]] >> * lisp/emacs-lisp/lisp.el (mark-defun): simplify moving the point > > Missing capitalization and period (if you're not just squashing this). > > > [[b8fd2c2ca1]] >> * Fix elisp-tests-with-temp-buffer compilation > [...] > > Please add to this the patch from > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21072#254. > > [[7efd2f2ea1]] >> Modify `beginning-of-defun-comments' > > If you are keeping this one, I would add to the commit message: > > * lisp/emacs-lisp/lisp.el (beginning-of-defun-comments): Try not to stop > in the middle of a multiline comment. Thanks. All done, branch deleted and pushed again. Hopefully it's ok now. (I'm still learning to write commit messages...) Best, -- Marcin Borkowski