From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25025: python-shell-calculate-command is wrong Date: Wed, 16 Aug 2017 07:08:55 -0400 Message-ID: <87inhnzs54.fsf@users.sourceforge.net> References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <87pol1ekko.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1502881701 9213 195.159.176.226 (16 Aug 2017 11:08:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Aug 2017 11:08:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 25025@debbugs.gnu.org To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 16 13:08:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhwBI-0001tj-41 for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Aug 2017 13:08:12 +0200 Original-Received: from localhost ([::1]:38662 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhwBO-0002Dj-0e for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Aug 2017 07:08:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhwBD-0002Bb-MG for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 07:08:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhwB8-0000j3-MR for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 07:08:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59809) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhwB8-0000ix-Ie for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 07:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhwB8-0006cQ-DT for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 07:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Aug 2017 11:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed confirmed Original-Received: via spool by 25025-submit@debbugs.gnu.org id=B25025.150288164525396 (code B ref 25025); Wed, 16 Aug 2017 11:08:02 +0000 Original-Received: (at 25025) by debbugs.gnu.org; 16 Aug 2017 11:07:25 +0000 Original-Received: from localhost ([127.0.0.1]:40257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhwAX-0006bY-DZ for submit@debbugs.gnu.org; Wed, 16 Aug 2017 07:07:25 -0400 Original-Received: from mail-io0-f173.google.com ([209.85.223.173]:34062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhwAW-0006bK-Bs for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 07:07:24 -0400 Original-Received: by mail-io0-f173.google.com with SMTP id o9so11932119iod.1 for <25025@debbugs.gnu.org>; Wed, 16 Aug 2017 04:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4wqeDQrtixnWXBRDzpWKhejEgT//KztJ9ravlqtqlwY=; b=iQjshzPxZ8L/TKi4KrYys3ki/ckI4RPRZh2O/Ra4JouUpeKmaRUiS0Dqe2ZuuPGgQt SyLmXWr7o3wz3Rt5USqI5r9rsXFaw8Og0Cwz8Vj/zbPvv/ti7h9qRkCGw4AOMhmX8hYp 1AueZ7a46J4lIsvkPhcVGcXfn8+kjonG6cuTE3DN4fVGnL3ftUy3ATVF9ZU/8PDIe6RR gPN0hY3om60XJZUVezM65VsSTpfysiF/Kp7H2/TDTE4gIBs43ES8Dz0+S2dxjH9ix9Xf 7aUPG0O8ImJBq+JZ6VTD5vNhLvbYrf0G5+z1JWXr4dxGAwfi7gtg2rAdqhjcMnObrihY m1Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=4wqeDQrtixnWXBRDzpWKhejEgT//KztJ9ravlqtqlwY=; b=o6SkTFJfUxILKn1M5kn33NUoMTFFTIjzhS6Za3qywJY7y5zT/0OPcs4eF0nYS+0qoa G/FiYv61J2RGcxkQNTPe4xreWnlbnWDQLFd4ZxrRePImRgpt2teoAVu87NVvJTFPOwg6 bFSQSh+sJw5g547oGjyoOLg2V2IqN9OY3PaOLmGjiKQ9bdbIHZstFXpaDNXqCuWlxlMP UQ6Ug2d3a1juRsLcMOCD5ZScyrOU70rwQGoXkyLWLJwBWc/UWoRN2fzWZv2nQMtEtS43 8wEOoVz0Z6DF9YTGm8Fj57tEyO19QTVwbJAzqLVuFkg7chxrPe00uckiWM5I2I1wf2nP PRaw== X-Gm-Message-State: AHYfb5gs07UencS+lfT2iAVwhvbVTjUyjLiLeBT5LeQNnUa8Q07GJBsb tsXR3MXHO3tRCA== X-Received: by 10.107.128.85 with SMTP id b82mr1144601iod.179.1502881637936; Wed, 16 Aug 2017 04:07:17 -0700 (PDT) Original-Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id y72sm217015iod.40.2017.08.16.04.07.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Aug 2017 04:07:16 -0700 (PDT) In-Reply-To: <87pol1ekko.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Fri, 09 Dec 2016 00:29:59 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135805 Archived-At: --=-=-= Content-Type: text/plain npostavs@users.sourceforge.net writes: > Okay, it looks like the consensus is that we should apply the > `combine-and-quote-strings' fix for now, and possibly in future switch > to something more shell based. > > I've pushed it to master as 8f611e5e2309 "Fix bad quoting of > python-shell-interpreter", and I'm closing this bug. This broke the test python-shell-calculate-command-1 on Windows. We could update the test to match the new python-shell-calculate-command implementation, but since the test body is basically just a copy of that function, it looks pretty useless to me. I think we should just remove that test. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Remove-python-shell-calculate-command-1-test.patch Content-Description: patch >From 1173da346a388a7258a8b462ef5a5d9416781245 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 16 Aug 2017 07:06:38 -0400 Subject: [PATCH] ; Remove python-shell-calculate-command-1 test * test/lisp/progmodes/python-tests.el (python-shell-calculate-pythonpath-1): Remove, it merely reprises the body of `python-shell-calculate-command' and it has been broken on w32 since the fix for Bug#25025 was applied. --- test/lisp/progmodes/python-tests.el | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el index 8795da4ef4..1a8c6a4e8c 100644 --- a/test/lisp/progmodes/python-tests.el +++ b/test/lisp/progmodes/python-tests.el @@ -2546,20 +2546,6 @@ python-tests-shell-interpreter (should (string= (python-shell-internal-get-process-name) (format "%s[%s]" python-shell-internal-buffer-name (buffer-name)))))) -(ert-deftest python-shell-calculate-command-1 () - "Check the command to execute is calculated correctly. -Using `python-shell-interpreter' and -`python-shell-interpreter-args'." - (skip-unless (executable-find python-tests-shell-interpreter)) - (let ((python-shell-interpreter (executable-find - python-tests-shell-interpreter)) - (python-shell-interpreter-args "-B")) - (should (string= - (format "%s %s" - (shell-quote-argument python-shell-interpreter) - python-shell-interpreter-args) - (python-shell-calculate-command))))) - (ert-deftest python-shell-calculate-pythonpath-1 () "Test PYTHONPATH calculation." (let ((process-environment '("PYTHONPATH=/path0")) -- 2.14.1 --=-=-=--