From: npostavs@users.sourceforge.net
To: "Clément Pit--Claudel" <clement.pit@gmail.com>
Cc: 25025@debbugs.gnu.org
Subject: bug#25025: python-shell-calculate-command is wrong
Date: Wed, 16 Aug 2017 07:08:55 -0400 [thread overview]
Message-ID: <87inhnzs54.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87pol1ekko.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Fri, 09 Dec 2016 00:29:59 -0500")
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
npostavs@users.sourceforge.net writes:
> Okay, it looks like the consensus is that we should apply the
> `combine-and-quote-strings' fix for now, and possibly in future switch
> to something more shell based.
>
> I've pushed it to master as 8f611e5e2309 "Fix bad quoting of
> python-shell-interpreter", and I'm closing this bug.
This broke the test python-shell-calculate-command-1 on Windows. We
could update the test to match the new python-shell-calculate-command
implementation, but since the test body is basically just a copy of that
function, it looks pretty useless to me. I think we should just remove
that test.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1743 bytes --]
From 1173da346a388a7258a8b462ef5a5d9416781245 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Wed, 16 Aug 2017 07:06:38 -0400
Subject: [PATCH] ; Remove python-shell-calculate-command-1 test
* test/lisp/progmodes/python-tests.el
(python-shell-calculate-pythonpath-1): Remove, it merely reprises the
body of `python-shell-calculate-command' and it has been broken on w32
since the fix for Bug#25025 was applied.
---
test/lisp/progmodes/python-tests.el | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el
index 8795da4ef4..1a8c6a4e8c 100644
--- a/test/lisp/progmodes/python-tests.el
+++ b/test/lisp/progmodes/python-tests.el
@@ -2546,20 +2546,6 @@ python-tests-shell-interpreter
(should (string= (python-shell-internal-get-process-name)
(format "%s[%s]" python-shell-internal-buffer-name (buffer-name))))))
-(ert-deftest python-shell-calculate-command-1 ()
- "Check the command to execute is calculated correctly.
-Using `python-shell-interpreter' and
-`python-shell-interpreter-args'."
- (skip-unless (executable-find python-tests-shell-interpreter))
- (let ((python-shell-interpreter (executable-find
- python-tests-shell-interpreter))
- (python-shell-interpreter-args "-B"))
- (should (string=
- (format "%s %s"
- (shell-quote-argument python-shell-interpreter)
- python-shell-interpreter-args)
- (python-shell-calculate-command)))))
-
(ert-deftest python-shell-calculate-pythonpath-1 ()
"Test PYTHONPATH calculation."
(let ((process-environment '("PYTHONPATH=/path0"))
--
2.14.1
next prev parent reply other threads:[~2017-08-16 11:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 6:24 bug#25025: python-shell-calculate-command is wrong Fabrice Popineau
2016-11-25 7:03 ` Clément Pit--Claudel
2016-11-25 8:32 ` Eli Zaretskii
2016-11-25 14:44 ` Clément Pit--Claudel
2016-11-25 14:59 ` Noam Postavsky
2016-11-26 18:43 ` Eli Zaretskii
2016-11-27 0:50 ` Noam Postavsky
2016-11-27 2:35 ` Clément Pit--Claudel
2016-11-27 15:56 ` Eli Zaretskii
2016-11-27 16:06 ` npostavs
2016-11-27 16:12 ` Eli Zaretskii
2016-11-28 8:42 ` Andreas Röhler
2016-11-28 14:15 ` npostavs
2016-11-28 16:43 ` Andreas Röhler
2016-11-30 0:39 ` npostavs
2016-11-30 6:39 ` Andreas Röhler
2016-11-30 17:12 ` Clément Pit--Claudel
2016-11-30 0:36 ` npostavs
2016-11-30 1:35 ` Clément Pit--Claudel
2016-11-30 1:56 ` npostavs
2016-11-30 15:55 ` Eli Zaretskii
2016-11-30 22:10 ` Noam Postavsky
2016-12-01 17:10 ` Eli Zaretskii
2016-12-02 1:12 ` npostavs
2016-12-02 7:35 ` Eli Zaretskii
2016-12-02 14:16 ` Noam Postavsky
2016-12-02 14:51 ` Eli Zaretskii
2016-12-02 15:07 ` npostavs
2016-12-02 15:46 ` Eli Zaretskii
2016-12-02 16:15 ` Clément Pit--Claudel
2016-12-02 16:41 ` Noam Postavsky
2016-12-02 16:58 ` Clément Pit--Claudel
2016-12-09 5:29 ` npostavs
2017-08-16 11:08 ` npostavs [this message]
2017-08-16 14:32 ` Eli Zaretskii
2017-08-16 16:50 ` Noam Postavsky
2017-08-16 16:57 ` Eli Zaretskii
2017-08-16 19:27 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inhnzs54.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=25025@debbugs.gnu.org \
--cc=clement.pit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.